MDL-5696 fixed 'Checkbox' actually allows 'checkboxes' and empty 'options' (radio...

diff --git a/mod/data/field/checkbox/field.class.php b/mod/data/field/checkbox/field.class.php
index a5912ac408ebceb8180bf97f2fe4f480213aa398..93aa699efccbde94d6c2bfe5a022f6c54d7058c8 100755 (executable)
--- a/mod/data/field/checkbox/field.class.php
+++ b/mod/data/field/checkbox/field.class.php
@@ -46,6 +46,9 @@ class data_field_checkbox extends data_field_base {
         $i = 0;
         foreach (explode("\n", $this->field->param1) as $checkbox) {
             $checkbox = trim($checkbox);
+            if ($checkbox === '') {
+                continue; // skip empty lines
+            }
             $str .= '<input type="checkbox" id="field_'.$this->field->id.'_'.$i.'" name="field_' . $this->field->id . '[]" ';
             $str .= 'value="' . s($checkbox) . '" ';
             

diff --git a/mod/data/field/radiobutton/field.class.php b/mod/data/field/radiobutton/field.class.php
index a208898735c8d831f1e518acf1405b21ce381865..cd1a4005a2c58ef555d39728088035c9fa73d188 100755 (executable)
--- a/mod/data/field/radiobutton/field.class.php
+++ b/mod/data/field/radiobutton/field.class.php
@@ -46,6 +46,9 @@ class data_field_radiobutton extends data_field_base {
         $i = 0;
         foreach (explode("\n",$this->field->param1) as $radio) {
             $radio = trim($radio);
+            if ($radio === '') {
+                continue; // skip empty lines
+            }
             $str .= '<input type="radio" id="field_'.$this->field->id.'_'.$i.'" name="field_' . $this->field->id . '" ';
             $str .= 'value="' . s($radio) . '" ';