setup: Need memory before setup_DB.

I was getting an interesting failure with $CFG->prefix commented
out in config.php (by mistake!). Abbreviated stack trace
lib/setup.php -> setup_DB -> dml_exception('prefixcannotbeempty') ->
  get_string -> string_manager->__construct -> get_plugin_types

That loads lib.php from every module, which runs out of memeory.

diff --git a/lib/setup.php b/lib/setup.php
index 286718b4009a4b543f3896c7df1f60cc2f36415d..66339af6ef1ebe918c2f625dc05fb291cd8fb974 100644 (file)
--- a/lib/setup.php
+++ b/lib/setup.php
@@ -262,11 +262,11 @@ global $SCRIPT;
 /// make sure PHP is not severly misconfigured
     setup_validate_php_configuration();
 
-/// Connect to the database
-    setup_DB();
-
 /// Increase memory limits if possible
-    raise_memory_limit('96M');    // We should never NEED this much but just in case...
+    //raise_memory_limit('96M');    // We should never NEED this much but just in case...
+
+    /// Connect to the database
+    setup_DB();
 
 /// Disable errors for now - needed for installation when debug enabled in config.php
     if (isset($CFG->debug)) {