Fix PHP error which comes because session_start() is called before the obgzhandler...

Currently this is more a hotfix - it effectively disables gzcompression on servers with use_trans_sid. We would need to move serendipity_gzCompression before session_start, but I don't dare touch this beast I have no knowledge of. Tom?

diff --git a/docs/NEWS b/docs/NEWS
index 4f41986031fdc558067c66be47bfcaf05e9c06a9..ad07b0a48c844c453bba5721cd56dce965b00ec4 100644 (file)
--- a/docs/NEWS
+++ b/docs/NEWS
@@ -3,6 +3,11 @@
 Version 0.9 ()
 ------------------------------------------------------------------------
 
+    * Fix error "Warning: ob_start(): output handler 'ob_gzhandler' 
+      cannot be used after 'URL-Rewriter'" which can occur on installations
+      where session.use_trans_sid is activated and Serendipity's gzip
+      compression is used. (garvinhicking)
+
     * Adjusted checking for "convert" binary in installation for
       Windows servers. Thanks to BobRock! (garvinhicking)
 

diff --git a/include/functions.inc.php b/include/functions.inc.php
index 30c270ee1c23e437a6810b090d1ab53ae50c6893..254f0413a92b4b8ec63bda75b4da357539c37c85 100644 (file)
--- a/include/functions.inc.php
+++ b/include/functions.inc.php
@@ -24,7 +24,7 @@ function serendipity_truncateString($s, $len) {
 
 function serendipity_gzCompression() {
     global $serendipity;
-    if (isset($serendipity['useGzip']) && serendipity_db_bool($serendipity['useGzip']) && function_exists('ob_gzhandler') && extension_loaded('zlib') && serendipity_ini_bool(ini_get('zlib.output_compression')) == false) {
+    if (isset($serendipity['useGzip']) && serendipity_db_bool($serendipity['useGzip']) && function_exists('ob_gzhandler') && extension_loaded('zlib') && serendipity_ini_bool(ini_get('zlib.output_compression')) == false && serendipity_ini_bool(ini_get('session.use_trans_sid')) == false) {
         ob_start("ob_gzhandler");
     }
 }