Fix for Bug #5419 - Inconsistency between log_display and log tables

diff --git a/lib/db/mysql.php b/lib/db/mysql.php
index f04473808896224887c5d573b2ff0b4b9637138f..d8f00adb928f0994b3c483c7d8b987a2c83fb684 100644 (file)
--- a/lib/db/mysql.php
+++ b/lib/db/mysql.php
@@ -1921,7 +1921,6 @@ function main_upgrade($oldversion=0) {
         table_column('user','url','url','varchar','255','','','not null');
     }
     
-    
     if ($oldversion < 2006050400) {
 
         execute_sql("ALTER TABLE `{$CFG->prefix}user` DROP INDEX {$CFG->prefix}user_deleted_idx;",false);
@@ -1943,6 +1942,10 @@ function main_upgrade($oldversion=0) {
         execute_sql("ALTER TABLE `{$CFG->prefix}user` ADD INDEX user_email (email)",false);
     }
     
+    if ($oldversion < 2006050500) {
+        table_column('log', 'action', 'action', 'varchar', '40', '', '', 'not null');
+    }
+    
     return $result;
 }
 

diff --git a/lib/db/mysql.sql b/lib/db/mysql.sql
index 3eaf44c6df7823c85555eddc0eb2be6f31ce2cc7..7e6a8d9704961cddb137404decbcde9e7683118c 100644 (file)
--- a/lib/db/mysql.sql
+++ b/lib/db/mysql.sql
@@ -415,7 +415,7 @@ CREATE TABLE `prefix_log` (
   `course` int(10) unsigned NOT NULL default '0',
   `module` varchar(20) NOT NULL default '',
   `cmid` int(10) unsigned NOT NULL default '0',
-  `action` varchar(15) NOT NULL default '',
+  `action` varchar(40) NOT NULL default '',
   `url` varchar(100) NOT NULL default '',
   `info` varchar(255) NOT NULL default '',
   PRIMARY KEY  (`id`),
@@ -433,10 +433,10 @@ CREATE TABLE `prefix_log` (
 
 CREATE TABLE `prefix_log_display` (
   `id` int(10) unsigned NOT NULL auto_increment,
-  `module` varchar(20) NOT NULL default '',
-  `action` varchar(20) NOT NULL default '',
-  `mtable` varchar(20) NOT NULL default '',
-  `field` varchar(40) NOT NULL default '',
+  `module` varchar(30) NOT NULL default '',
+  `action` varchar(40) NOT NULL default '',
+  `mtable` varchar(30) NOT NULL default '',
+  `field` varchar(50) NOT NULL default '',
    PRIMARY KEY  (`id`)
 ) TYPE=MyISAM COMMENT='For a particular module/action, specifies a moodle table/field.';
 ALTER TABLE prefix_log_display ADD UNIQUE `moduleaction`(`module` , `action`);

diff --git a/lib/db/postgres7.php b/lib/db/postgres7.php
index b1d783e8046edece72e82f93ca346257f49af043..0a859399265201d91b8f49d5f6c600af34471e6f 100644 (file)
--- a/lib/db/postgres7.php
+++ b/lib/db/postgres7.php
@@ -1529,8 +1529,12 @@ function main_upgrade($oldversion=0) {
         modify_database('',"CREATE INDEX tags_typeuserid_idx ON prefix_tags (type, userid);");
         modify_database('',"CREATE INDEX tags_text_idx ON prefix_tags (text);");
     }
-
+    
+    if ($oldversion < 2006050500) {
+        table_column('log', 'action', 'action', 'varchar', '40', '', '', 'not null');
+    }
+    
     return $result;
 }
 
-?>
+?>
\ No newline at end of file

diff --git a/lib/db/postgres7.sql b/lib/db/postgres7.sql
index 0026c15b98bc769034e2ec2ecdf4d5bb4fb4a4c8..7742e45696a00f0deb1787ea30e146dc54b27f1f 100644 (file)
--- a/lib/db/postgres7.sql
+++ b/lib/db/postgres7.sql
@@ -259,7 +259,7 @@ CREATE TABLE prefix_log (
    course integer NOT NULL default '0',
    module varchar(20) NOT NULL default '',
    cmid integer NOT NULL default '0',
-   action varchar(20) NOT NULL default '',
+   action varchar(40) NOT NULL default '',
    url varchar(100) NOT NULL default '',
    info varchar(255) NOT NULL default ''
 );