At last, fixed that despicable notice when logging in by converting direct

array access to get_user_preference(), as it should be.

Removed reload_user_preferences() call, it's not needed and I saw one other
such call somewhere around here which M.D. has commented out (without creating
trouble, obviously).

diff --git a/login/index.php b/login/index.php
index 47fc12b49de5f581b298a2963bf25866e59b1082..aa6352a1e7ff687b916226b3b3b26b61f1e5e400 100644 (file)
--- a/login/index.php
+++ b/login/index.php
@@ -100,8 +100,7 @@
             
 
             // check whether the user should be changing password
-            reload_user_preferences();
-            if ($USER->preference['auth_forcepasswordchange']){
+            if (get_user_preferences('auth_forcepasswordchange', false)){
                 if (isset($passwordchangeurl)) {
                     redirect($passwordchangeurl);
                 } else {