Fixing bug where quizzes from 1.4 will lose their answers when upgraded to later...

Fixes MDL-8207.

diff --git a/mod/quiz/locallib.php b/mod/quiz/locallib.php
index 72ca3f02b37e9d005c6038902e8684b1f3ec5303..d2e545997d2bea625454e5313cdfb01876d1cfbe 100644 (file)
--- a/mod/quiz/locallib.php
+++ b/mod/quiz/locallib.php
@@ -587,11 +587,11 @@ function quiz_upgrade_states($attempt) {
     // Actually we only do this for states whose question is actually listed in $attempt->layout.
     // We do not do it for states associated to wrapped questions like for example the questions
     // used by a RANDOM question
-    $newest->attemptid = $attempt->uniqueid;
+    $session = new stdClass;
+    $session->attemptid = $attempt->uniqueid;
     $questionlist = quiz_questions_in_quiz($attempt->layout);
     if ($questionlist and $states = get_records_select('question_states', "attempt = '$attempt->uniqueid' AND question IN ($questionlist)")) {
         foreach ($states as $state) {
-            $session = new stdClass;
             $session->newgraded = $state->id;
             $session->newest = $state->id;
             $session->questionid = $state->question;