webservice MDL-20805 change NOT IN for NOT EXISTS

diff --git a/admin/webservice/forms.php b/admin/webservice/forms.php
index e763b3e07da781fb7ce5800ed956ccd1eb4851fc..97217c10a0bd70efb377b252f450ebfc0009ba8f 100644 (file)
--- a/admin/webservice/forms.php
+++ b/admin/webservice/forms.php
@@ -144,9 +144,9 @@ class web_service_token_form extends moodleform {
             //user searchable selector
             $sql = "SELECT user.id, user.firstname, user.lastname
             FROM {user} user
-            WHERE user.id NOT IN (  SELECT adminuser.id
+            WHERE NOT EXISTS ( SELECT adminuser.id
                                     FROM {user} adminuser, {role_assignments} rassign
-                                    WHERE rassign.roleid = 1 AND rassign.userid = adminuser.id)
+                                    WHERE adminuser.id=user.id AND rassign.roleid = 1 AND rassign.userid = adminuser.id)
             ORDER BY user.lastname";
             $users = $DB->get_records_sql($sql,array());
             $options = array();