Fix from Bernard Boucher for situation when no groups members defined

   http://moodle.org/mod/forum/discuss.php?d=6335#29657

diff --git a/mod/survey/lib.php b/mod/survey/lib.php
index 64ad234cd6d8e55fff1949e23a73f34f048d0836..0af4a67ef4952b3cfc39ebc6f45adfe09c0b19b5 100644 (file)
--- a/mod/survey/lib.php
+++ b/mod/survey/lib.php
@@ -189,16 +189,17 @@ function survey_get_responses($surveyid, $groupid) {
     global $CFG;
 
     if ($groupid) {
+        $groupsdb = ", {$CFG->prefix}groups_members AS gm";
         $groupsql = "AND gm.groupid = $groupid AND u.id = gm.userid";
     } else {
+        $groupsdb = "";
         $groupsql = "";
     }
 
     return get_records_sql("SELECT MAX(a.time) as time, 
                                    u.id, u.firstname, u.lastname, u.picture
                               FROM {$CFG->prefix}survey_answers AS a, 
-                                   {$CFG->prefix}user AS u,
-                                   {$CFG->prefix}groups_members AS gm
+                                   {$CFG->prefix}user AS u   $groupsdb
                              WHERE a.survey = $surveyid 
                                    AND a.userid = u.id $groupsql
                           GROUP BY u.id, u.firstname, u.lastname