MDL-17365 forum rate - validate rating against scale values. Merged from 19_STABLE

diff --git a/mod/forum/rate.php b/mod/forum/rate.php
index 1879f4d34bc9838869511b8ef6674eea0f1a1be5..0f7a1240f7cbf9d69d1c7a319b6318f5c3c2ea9b 100644 (file)
--- a/mod/forum/rate.php
+++ b/mod/forum/rate.php
@@ -40,6 +40,9 @@
 
         $discussionid = false;
 
+    /// Calculate scale values
+        $scale_values = make_grades_menu($forum->scale);
+
         foreach ((array)$data as $postid => $rating) {
             if (!is_numeric($postid)) {
                 continue;
@@ -63,6 +66,11 @@
                 }
             }
 
+        /// Check rate is valid for for that forum scale values
+            if (!array_key_exists($rating, $scale_values) && $rating != FORUM_UNSET_POST_RATING) {
+                print_error('invalidrate', 'forum', '', $rating);
+            }
+
             if ($rating == FORUM_UNSET_POST_RATING) {
                 $DB->delete_records('forum_ratings', array('post' => $postid, 'userid' => $USER->id));
                 forum_update_grades($forum, $post->userid);