MDL-13936 users without accessallgroups can post start discussions only in own groups...

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index b5e0fa79bc156713a1c1d93190b52b5e18ff16ca..d5b2158f9e048a9ffe2ced997e228ccafbfabd51 100644 (file)
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -4249,12 +4249,9 @@ function forum_user_can_post_discussion($forum, $currentgroup=null, $unused=-1,
     if ($currentgroup) {
         return groups_is_member($currentgroup);
     } else {
-        //else it might be group 0 in visible mode
-        if ($groupmode == VISIBLEGROUPS){
-            return true;
-        } else {
-            return false;
-        }
+        // no group membership and no accessallgroups means no new discussions
+        // reverted to 1.7 behaviour in 1.9+,  buggy in 1.8.0-1.9.0
+        return false;
     }
 }