Fixing one SQL that could cause problems with coincidences

in the associative array. MDL-10787

Merged from MOODLE_18_STABLE

diff --git a/mod/survey/lib.php b/mod/survey/lib.php
index 26e3a5496519e2c464279e669431e5086b3210b4..b7a491f0f493f0bd12999cd80197611ba97bf0db 100644 (file)
--- a/mod/survey/lib.php
+++ b/mod/survey/lib.php
@@ -224,14 +224,13 @@ function survey_get_responses($surveyid, $groupid) {
         $groupsql = "";
     }
 
-    return get_records_sql("SELECT MAX(a.time) as time, 
-                                   u.id, u.firstname, u.lastname, u.picture
-                              FROM {$CFG->prefix}survey_answers a, 
-                                   {$CFG->prefix}user u   $groupsdb
-                             WHERE a.survey = $surveyid 
-                                   AND a.userid = u.id $groupsql
-                          GROUP BY u.id, u.firstname, u.lastname, u.picture
-                          ORDER BY time ASC");
+    return get_records_sql("SELECT u.id, u.firstname, u.lastname, u.picture, MAX(a.time) as time
+                            FROM {$CFG->prefix}survey_answers a,
+                                 {$CFG->prefix}user u   $groupsdb
+                            WHERE a.survey = $surveyid
+                              AND a.userid = u.id $groupsql
+                            GROUP BY u.id, u.firstname, u.lastname, u.picture
+                            ORDER BY time ASC");
 }
 
 function survey_get_analysis($survey, $user) {