Bug #6147 - Upgrade from 1.5.x breaks with Postgres 7.4.x

Even though Postgres 7.4.x is officially supported, several upgrade scripts use syntax that only works in Postgres 8.x. and it's impossible to finish the upgrade.

The attached patch fixes those scripts.

Saludos. I�aki.

Author: I�aki Arenaza
Review: Jun Yamog, Martin Langhoff

merged from MOODLE_16_STABLE

diff --git a/lib/db/postgres7.php b/lib/db/postgres7.php
index 6d5c8d0c49e5b343fec6a7c29a21750a5a935e02..359a03652c82100f3fcd793efd4a4d805bd40c19 100644 (file)
--- a/lib/db/postgres7.php
+++ b/lib/db/postgres7.php
@@ -1544,18 +1544,14 @@ function main_upgrade($oldversion=0) {
             }
         }
 
-        modify_database('', 'ALTER TABLE prefix_course_request
-            ALTER COLUMN "password" TYPE varchar(50),
-            ALTER COLUMN "password" SET DEFAULT \'\'');
+        table_column('course_request', 'password', 'password', 'varchar', '50', '', '');
 
-        modify_database('', 'ALTER TABLE prefix_course
-            ALTER COLUMN currency TYPE varchar(3)');
+        table_column('course', 'currency', 'currency', 'varchar', '3');
 
         modify_database('', 'ALTER TABLE prefix_course_categories
             ALTER COLUMN path SET DEFAULT \'\'');
 
-        modify_database('', 'ALTER TABLE prefix_log_display
-            ALTER COLUMN module TYPE varchar(20)');
+        table_column('log_display', 'module', 'module', 'varchar', '20');
 
         modify_database("","DROP INDEX id_user_idx");
         modify_database("","DROP INDEX post_lastmodified_idx");