MDL-12756 print save button in admin search only when there are settings to save...

diff --git a/admin/search.php b/admin/search.php
index c07f86241ac969dc73d489ac9a11f9f2328878bd..4fcde9546a3d90c7da2d531bf2d046ac063ffe4c 100644 (file)
--- a/admin/search.php
+++ b/admin/search.php
@@ -51,7 +51,6 @@ echo '<fieldset>';
 echo '<div class="clearer"><!-- --></div>';
 if ($resultshtml != '') {
     echo $resultshtml;
-    echo '<div class="form-buttons"><input class="form-submit" type="submit" value="'.get_string('savechanges','admin').'" /></div>';
 } else {
     echo get_string('noresults','admin');
 }

diff --git a/lib/adminlib.php b/lib/adminlib.php
index dea854e25ad1bfaaf3f4057c0533acc3fa78b6a8..e39627d0b91c1e52022a43029dc833f6b85aff82 100644 (file)
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -4177,6 +4177,7 @@ function admin_search_settings_html($query) {
     $adminroot =& admin_get_root();
     $findings = $adminroot->search($query);
     $return = '';
+    $savebutton = false;
 
     foreach ($findings as $found) {
         $page     = $found->page;
@@ -4193,6 +4194,7 @@ function admin_search_settings_html($query) {
             continue;
         }
         if (!empty($settings)) {
+            $savebutton = true;
             $return .= '<fieldset class="adminsettings">'."\n";
             foreach ($settings as $setting) {
                 $return .= '<div class="clearer"><!-- --></div>'."\n";
@@ -4211,6 +4213,10 @@ function admin_search_settings_html($query) {
         }
     }
 
+    if ($savebutton) {
+         $return .= '<div class="form-buttons"><input class="form-submit" type="submit" value="'.get_string('savechanges','admin').'" /></div>';
+    }
+
     return $return;
 }