MDL-15071 improved error logging - credit goes to Andrei Bautu

diff --git a/lib/dml/pdo_moodle_database.php b/lib/dml/pdo_moodle_database.php
index 1a432252f1c7c802069adbf8d99b17265fd01efa..fbc8369fe709fb10face0112e62e3c6029dbb9c8 100644 (file)
--- a/lib/dml/pdo_moodle_database.php
+++ b/lib/dml/pdo_moodle_database.php
@@ -177,7 +177,18 @@ abstract class pdo_moodle_database extends moodle_database {
      * @return bool success
      */
     public function change_database_structure($sql) {
-        return $this->execute($sql);
+        try {
+            $this->lastError = null;
+            if($this->debug) {
+                $this->debug_query($sql);
+            }
+            $this->pdb->exec($sql);
+            return true;
+        } catch (PDOException $ex) {
+            $this->lastError = $ex->getMessage();
+            $this->report_error($sql, null, $ex);
+            return false;
+        }
     }
 
     public function delete_records_select($table, $select, array $params=null) {