]> git.mjollnir.org Git - moodle.git/commitdiff
Added logic in function forum_get_recent_mod_activity for groups
authorselliott <selliott>
Fri, 20 Feb 2004 21:52:56 +0000 (21:52 +0000)
committerselliott <selliott>
Fri, 20 Feb 2004 21:52:56 +0000 (21:52 +0000)
mod/forum/lib.php

index 7ba8e0171cad9dd8594da665f9c6525088806281..41cba5fbae25ce4cfc81aea4b71e163546e3b060 100644 (file)
@@ -2308,12 +2308,6 @@ function forum_get_recent_mod_activity(&$activities, &$index, $sincetime, $cours
         $userselect = "";
     }
 
-    if ($groupid) {
-        $groupselect = " AND d.groupid = '$groupid'";
-    } else {
-        $groupselect = "";
-    }
-
     $posts = get_records_sql("SELECT p.*, d.name, u.firstname, u.lastname,
                                      u.picture, d.groupid, cm.instance, f.name, cm.section
                                FROM {$CFG->prefix}forum_posts p,
@@ -2331,32 +2325,35 @@ function forum_get_recent_mod_activity(&$activities, &$index, $sincetime, $cours
                                 AND f.id = d.forum
                               ORDER BY d.id");
 
-  if (empty($posts))
-    return;
-
-  foreach ($posts as $post) {
-    $tmpactivity->type = "forum";
-    $tmpactivity->defaultindex = $index;
-    $tmpactivity->instance = $post->instance;
-    $tmpactivity->name = $post->name;
-    $tmpactivity->section = $post->section;
+    if (empty($posts))
+      return;
 
-    $tmpactivity->content->id = $post->id;
-    $tmpactivity->content->discussion = $post->discussion;
-    $tmpactivity->content->subject = $post->subject;
-    $tmpactivity->content->parent = $post->parent;
+    foreach ($posts as $post) {
 
-    $tmpactivity->user->userid = $post->userid;
-    $tmpactivity->user->fullname = fullname($post);
-    $tmpactivity->user->picture = $post->picture;
+        if (empty($groupid) || ismember($groupid, $post->userid)) {
+            $tmpactivity->type = "forum";
+            $tmpactivity->defaultindex = $index;
+            $tmpactivity->instance = $post->instance;
+            $tmpactivity->name = $post->name;
+            $tmpactivity->section = $post->section;
 
-    $tmpactivity->timestamp = $post->modified;
-    $activities[] = $tmpactivity;
+            $tmpactivity->content->id = $post->id;
+            $tmpactivity->content->discussion = $post->discussion;
+            $tmpactivity->content->subject = $post->subject;
+            $tmpactivity->content->parent = $post->parent;
+  
+            $tmpactivity->user->userid = $post->userid;
+            $tmpactivity->user->fullname = fullname($post);
+            $tmpactivity->user->picture = $post->picture;
 
-    $index++;
-  }
+            $tmpactivity->timestamp = $post->modified;
+            $activities[] = $tmpactivity;
+  
+            $index++;
+        }
+    }
 
-  return;
+    return;
 }
 
 function forum_print_recent_mod_activity($activity, $course, $detail=false) {