MDL-16463 "Long group names can make drop down box too wide" added an if condition...

diff --git a/lang/en_utf8/quiz_overview.php b/lang/en_utf8/quiz_overview.php
index d17165b6e6a955e5c777f69ac00013233841f7d4..2f8fbd26b9f5f5aea432c9956a79f5627aa1946f 100644 (file)
--- a/lang/en_utf8/quiz_overview.php
+++ b/lang/en_utf8/quiz_overview.php
@@ -50,4 +50,5 @@ $string['showinggraded'] = 'Showing only the attempt graded for each user.';
 $string['showinggradedandungraded'] = 'Showing graded and ungraded attempts for each user. The one attempt for each user that is graded is highlighted. The grading method for this quiz is $a.';
 $string['showdetailedmarks'] = 'Show / download marks for each question';
 $string['studentingroup'] = '\'$a->coursestudent\' in group \'$a->groupname\'';
+$string['studentingrouplong'] = '\'$a->coursestudent\' in this group';
 ?>

diff --git a/mod/quiz/report/overview/overviewsettings_form.php b/mod/quiz/report/overview/overviewsettings_form.php
index 8441cab9cc0d6afa16e8de746d99b6a17d715b20..77ab6c35beaf1ba37bc2aea2567583223042eb3c 100644 (file)
--- a/mod/quiz/report/overview/overviewsettings_form.php
+++ b/mod/quiz/report/overview/overviewsettings_form.php
@@ -14,7 +14,11 @@ class mod_quiz_report_overview_settings extends moodleform {
             $a = new object();
             $a->coursestudent = $COURSE->students;
             $a->groupname = groups_get_group_name($this->_customdata['currentgroup']);
-            $studentsstring = get_string('studentingroup', 'quiz_overview', $a);
+            if (20 < strlen($a->groupname)){
+              $studentsstring = get_string('studentingrouplong', 'quiz_overview', $a);
+            } else {
+              $studentsstring = get_string('studentingroup', 'quiz_overview', $a);
+            }
         }
         $options = array();
         if (!$this->_customdata['currentgroup']){