accesslib: get_users_by_capability() fix subselect with ra.hidden

 MDL-12452

diff --git a/lib/accesslib.php b/lib/accesslib.php
index 1c8529b1584ae01865f04907b37e741735ed300e..2ece09de0abf253e4284c773ac532b116a423d4e 100755 (executable)
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -4282,8 +4282,10 @@ function get_users_by_capability($context, $capability, $fields='', $sort='',
     /// Set up hidden role-assignments sql
     if ($view && !has_capability('moodle/role:viewhiddenassigns', $context)) {
         $condhiddenra = 'AND ra.hidden = 0 ';
+        $sscondhiddenra = 'AND ssra.hidden = 0 ';
     } else {
         $condhiddenra = '';
+        $sscondhiddenra = '';
     }
 
     // Collect WHERE conditions
@@ -4354,7 +4356,7 @@ function get_users_by_capability($context, $capability, $fields='', $sort='',
                           FROM {$CFG->prefix}role_assignments ssra
                           WHERE ssra.contextid IN ($ctxids)
                                 AND ssra.roleid IN (".implode(',',$roleids) .")
-                                $condhiddenra
+                                $sscondhiddenra
                           ) ra ON ra.userid = u.id
                     $uljoin ";
         $where  = " WHERE u.deleted = 0 ";