accesslib: is_siteadmin() bugfixes

Fixed two horrid bugs in is_siteadmin(). Both userid and the check for
matching cpabilities lines were wrong.

diff --git a/lib/accesslib.php b/lib/accesslib.php
index 456e8cc59619ba3522923790ea15dc8b7d69405e..b6fb2412f924b0876bce247c55ea42111ca1ae8e 100755 (executable)
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -425,9 +425,9 @@ function is_siteadmin($userid) {
               ON (ra.roleid=rc.roleid AND rc.contextid=ctx.id)
             WHERE ctx.contextlevel=10
               AND rc.capability IN ('moodle/site:config', 'moodle/legacy:admin', 'moodle/site:doanything')       
-              AND u.id={$USER->id}";
+              AND u.id={$userid}";
 
-    $isadmin = (get_field_sql($sql) == 0);
+    $isadmin = (get_field_sql($sql) > 0);
     return $isadmin;
 }