fixed defaults for backups during installation

diff --git a/admin/adminlib.php b/admin/adminlib.php
index 7db9e22fefc19cc7c6d80af9475da1b4be980c32..86c9cca6a33f8b582b8c93def988941ce8f4b08e 100644 (file)
--- a/admin/adminlib.php
+++ b/admin/adminlib.php
@@ -1593,6 +1593,44 @@ function admin_externalpage_print_footer() {
     
 }
 
+// n.b. this function unconditionally applies default settings
+function apply_default_settings(&$node) {
+
+    global $CFG;
+
+    if (is_a($node, 'admin_category')) {
+        $entries = array_keys($node->children);
+        foreach ($entries as $entry) {
+            apply_default_settings($node->children[$entry]);
+        }
+        return;
+    } 
+
+    if (is_a($node, 'admin_settingpage')) { 
+        foreach ($node->settings as $setting) {
+                $CFG->{$setting->name} = $setting->defaultsetting;
+                $setting->write_setting($setting->defaultsetting);
+            unset($setting); // needed to prevent odd (imho) reference behaviour
+                             // see http://www.php.net/manual/en/language.references.whatdo.php#AEN6399
+        }
+        return;
+    }
+
+    return;
+
+}
+
+// n.b. this function unconditionally applies default settings
+function apply_default_exception_settings($defaults) {
+
+    global $CFG;
+
+    foreach($defaults as $key => $value) {
+            $CFG->$key = $value;
+            set_config($key, $value);
+    }
+
+}
 
 
 // Code to build admin-tree ----------------------------------------------------------------------------

diff --git a/admin/index.php b/admin/index.php
index 400e2da67c9ceeab6cce25ee0e08789ff11b7d5a..87ed57434d4aff48f556836269944cb90b678a80 100644 (file)
--- a/admin/index.php
+++ b/admin/index.php
@@ -571,44 +571,6 @@
 
     admin_externalpage_print_footer();
 
-// n.b. this function unconditionally applies default settings
-function apply_default_settings(&$node) {
-
-    global $CFG;
-
-    if (is_a($node, 'admin_category')) {
-        $entries = array_keys($node->children);
-        foreach ($entries as $entry) {
-            apply_default_settings($node->children[$entry]);
-        }
-        return;
-    } 
-
-    if (is_a($node, 'admin_settingpage')) { 
-        foreach ($node->settings as $setting) {
-                $CFG->{$setting->name} = $setting->defaultsetting;
-                $setting->write_setting($setting->defaultsetting);
-            unset($setting); // needed to prevent odd (imho) reference behaviour
-                             // see http://www.php.net/manual/en/language.references.whatdo.php#AEN6399
-        }
-        return;
-    }
-
-    return;
-
-}
-
-// n.b. this function unconditionally applies default settings
-function apply_default_exception_settings($defaults) {
-
-    global $CFG;
-
-    foreach($defaults as $key => $value) {
-            $CFG->$key = $value;
-            set_config($key, $value);
-    }
-    
-}
 
 
 ?>

diff --git a/backup/lib.php b/backup/lib.php
index 459274e3157fa2ea693e8b94e7851c733bec701b..95c768c25cfe8a39245b555d7b6ffff00efd512e 100644 (file)
--- a/backup/lib.php
+++ b/backup/lib.php
@@ -319,7 +319,7 @@
     /// This function upgrades the backup tables, if necessary
     /// It's called from admin/index.php, also backup.php and restore.php
     
-        global $CFG, $db;
+        global $CFG, $db, $ADMIN;
 
         require_once ("$CFG->dirroot/backup/version.php");  // Get code versions
 
@@ -345,6 +345,9 @@
             $db->debug = false;
             if ($status) {
                 if (set_config("backup_version", $backup_version) and set_config("backup_release", $backup_release)) {
+                    //initialize default backup settings now
+                    require_once($CFG->dirroot . '/admin/adminlib.php');
+                    apply_default_settings($ADMIN->locate('backups'));
                     notify(get_string("databasesuccess"), "green");
                     notify(get_string("databaseupgradebackups", "", $backup_version), "green");
                     print_continue($continueto);