MDL-12037 - backup does not report errors correctly in backup_module()

diff --git a/backup/backuplib.php b/backup/backuplib.php
index ea51459223515b7fcfaff42d8167f69adf0edc5c..690693fd7afbcf069bc1d635c402095bcc8e68d6 100644 (file)
--- a/backup/backuplib.php
+++ b/backup/backuplib.php
@@ -2247,6 +2247,7 @@
         global $CFG;
 
         $status = true;
+        $statusm = true;
 
         require_once($CFG->dirroot.'/mod/'.$module.'/backuplib.php');
 
@@ -2256,7 +2257,13 @@
             if (function_exists($onemodbackup)) {
                 foreach ($preferences->mods[$module]->instances as $instance => $object) {
                     if (!empty($object->backup)) {
-                        $status = $onemodbackup($bf,$preferences,$instance);
+                        $statusm = $onemodbackup($bf,$preferences,$instance);
+                        if (!$statusm) {
+                            if (!defined('BACKUP_SILENTLY')) {
+                                notify('backup of '.$module.'-'.$object->name.' failed.');
+                            }
+                            $status = false;
+                        }
                     }
                 }
             }  else {