user_set_preference(): minor optimisation

Don't update if the values already match...

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index af944264213331596da24f984925679391f8a152..3d63fd57e864ae8d2e01386bd4f48368d53b7bc7 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -786,6 +786,9 @@ function set_user_preference($name, $value, $otheruserid=NULL) {
         // no pernament storage for not-logged-in user and guest
 
     } else if ($preference = get_record('user_preferences', 'userid', $userid, 'name', addslashes($name))) {
+        if ($preference->value === $value) {
+            return true;
+        }
         if (!set_field('user_preferences', 'value', addslashes((string)$value), 'id', $preference->id)) {
             $return = false;
         }