There's no need to die with an error if groups_temp doesn't exist, is there?

diff --git a/group/db/upgrade.php b/group/db/upgrade.php
index 94f3f73f4dbee8f824748b6deec3b50ef011df01..cf77877483a829b72ec9eff9b3361b5a6f462da4 100644 (file)
--- a/group/db/upgrade.php
+++ b/group/db/upgrade.php
@@ -406,9 +406,7 @@ function xmldb_group_upgrade($oldversion=0) {
     }
 
     if ($result && $oldversion < 2007012400) {
-        if( table_exists(new XMLDBTable('groups_temp'))
-            && file_exists($CFG->dirroot.'/group/db/install.xml') ) {
-
+        if (table_exists(new XMLDBTable('groups_temp')) && file_exists($CFG->dirroot.'/group/db/install.xml')) {
             $groupupgrade = optional_param('confirmgroupupgrade', 0, PARAM_BOOL);
             if (empty($groupupgrade)) {
                 notice_yesno(get_string('upgradeconfirm', 'group'), 'index.php?confirmgroupupgrade=yes', 'index.php');
@@ -424,9 +422,6 @@ function xmldb_group_upgrade($oldversion=0) {
 
             ///$result = $result && groups_rename_db2($suffix='_temp_18');
         }
-        else {
-            error('Upgrade 2007012400 of groups failed! (Could not update version in config table)');
-        }
     }
 
     return $result;