proper initialisation of $oldquestionid; merged from MOODLE_16_STABLE

diff --git a/question/question.php b/question/question.php
index 398e97275ca91aaeff9aa986a5d046bc3a14ac67..4644179d4628c6e5cb5348baadefbac28d864bae 100644 (file)
--- a/question/question.php
+++ b/question/question.php
@@ -146,6 +146,7 @@
                 $replaceold   = !$hasresponses && $replaceinall;
             }
 
+            $oldquestionid = false;
             if (!$replaceold) { // create a new question
                 $oldquestionid = $question->id;
                 if (!$makecopy) {
@@ -161,7 +162,7 @@
                 error("Failed to save the question!");
             }
 
-            if(isset($oldquestionid)) {
+            if(!empty($oldquestionid)) {
                 // create version entries for different quizzes
                 $version = new object();
                 $version->oldquestion = $oldquestionid;