questions-type-calculated MDL-20275 Fixed bug causing error when upgrading

Bug was caused because $result was being set by database_manager::create_table which does not return a value

diff --git a/question/type/calculated/db/upgrade.php b/question/type/calculated/db/upgrade.php
index 6dbe8b9caf142f16745e9c9ddcc4e03837f8aaed..69978b11456aa3fcd01607e97f40972d81467f7c 100644 (file)
--- a/question/type/calculated/db/upgrade.php
+++ b/question/type/calculated/db/upgrade.php
@@ -51,7 +51,8 @@ function xmldb_qtype_calculated_upgrade($oldversion) {
 
     /// Conditionally launch create table for question_calculated_options
         if (!$dbman->table_exists($table)) {
-            $result = $dbman->create_table($table);
+            // $dbman->create_table doesnt return a result, we just have to trust it
+            $dbman->create_table($table);
         }
 
 /// calculated savepoint reached