Removed the setting of default values. The default is now just zero.

diff --git a/lib/accesslib.php b/lib/accesslib.php
index 5fd248bc843c3ab20fb408f213f05515c77b23c5..a9adcabe49fbe910d7644b62a9067c83f2eaf5e0 100755 (executable)
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -1010,10 +1010,6 @@ function moodle_install_roles() {
     allow_override($adminrole, $guestrole);    
 
 
-    /// Upgrade course table with defaultrole values
-    execute_sql('UPDATE '.$CFG->prefix.'course SET defaultrole = '.$studentrole);
-
-
     // Should we delete the tables after we are done? Not yet.
 }
 
@@ -2478,4 +2474,4 @@ function get_role_users($roleid, $context, $parent=false) {
     return get_records_sql($SQL);
 }
 
-?>
\ No newline at end of file
+?>

diff --git a/lib/db/mysql.php b/lib/db/mysql.php
index e9157c3f145e88ec281914790911aec24f9f98a9..9197490ca59750f44461c660eba525c21d21137e 100644 (file)
--- a/lib/db/mysql.php
+++ b/lib/db/mysql.php
@@ -2213,11 +2213,7 @@ function main_upgrade($oldversion=0) {
     }
 
     if ($oldversion < 2006091700) {
-        table_column('course','','defaultrole','int','10');
-        if ($studentroles = get_roles_with_capability('moodle/legacy:student', CAP_ALLOW)) {
-            $studentrole = array_shift($studentroles);   /// Take the first one
-            execute_sql('UPDATE '.$CFG->prefix.'course SET defaultrole = '.$studentrole->id);
-        }
+        table_column('course','','defaultrole','integer','10', 'unsigned', '0', 'not null');
     }
 
     return $result;

diff --git a/lib/db/postgres7.php b/lib/db/postgres7.php
index 5dde54f3a0e27870cd0193d2e5985a340aa4cc7b..5cc1e1bd194abaa7b33bccd92056269c9f2eab4b 100644 (file)
--- a/lib/db/postgres7.php
+++ b/lib/db/postgres7.php
@@ -1813,11 +1813,7 @@ function main_upgrade($oldversion=0) {
     }
 
     if ($oldversion < 2006091700) {
-        table_column('course','','defaultrole','int','10');
-        if ($studentroles = get_roles_with_capability('moodle/legacy:student', CAP_ALLOW)) {
-            $studentrole = array_shift($studentroles);   /// Take the first one
-            execute_sql('UPDATE '.$CFG->prefix.'course SET defaultrole = '.$studentrole->id);
-        }
+        table_column('course','','defaultrole','integer','10', 'unsigned', '0', 'not null');
     }
 
     return $result;