"MDL-13766, delete config if checkbox element is unchecked"

diff --git a/admin/repository.php b/admin/repository.php
index b26d89d1f0eae745c7d96d12860a4e68ede1f9b2..756faeb8aaa6f6806033756c1b7763fc34964634 100644 (file)
--- a/admin/repository.php
+++ b/admin/repository.php
@@ -70,23 +70,27 @@ if (!empty($edit) || !empty($new)) {
             foreach($configs as $config) {
                 if (!empty($fromform->$config)) {
                     $settings[$config] = $fromform->$config;
+                } else {
+                    // if the config name is not appear in $fromform
+                    // empty this config value
+                    $settings[$config] = '';
                 }
             }
              $instanceoptionnames = repository::static_function($edit, 'get_instance_option_names');
             if (!empty($instanceoptionnames)) {
-                    if (array_key_exists('enablecourseinstances', $fromform)) {
-                        $settings['enablecourseinstances'] = $fromform->enablecourseinstances;
-                    }
-                    else {
-                        $settings['enablecourseinstances'] = 0;
-                    }
-                    if (array_key_exists('enableuserinstances', $fromform)) {
-                        $settings['enableuserinstances'] = $fromform->enableuserinstances;
-                    }
-                    else {
-                        $settings['enableuserinstances'] = 0;
-                    }
+                if (array_key_exists('enablecourseinstances', $fromform)) {
+                    $settings['enablecourseinstances'] = $fromform->enablecourseinstances;
                 }
+                else {
+                    $settings['enablecourseinstances'] = 0;
+                }
+                if (array_key_exists('enableuserinstances', $fromform)) {
+                    $settings['enableuserinstances'] = $fromform->enableuserinstances;
+                }
+                else {
+                    $settings['enableuserinstances'] = 0;
+                }
+            }
             $success = $repositorytype->update_options($settings);
         } else {
             $type = new repository_type($plugin,(array)$fromform);