]> git.mjollnir.org Git - moodle.git/commitdiff
MDL-18517 Stats - Course Overview Weighted report returning incorrect information
authordanmarsden <danmarsden>
Fri, 13 Mar 2009 02:52:53 +0000 (02:52 +0000)
committerdanmarsden <danmarsden>
Fri, 13 Mar 2009 02:52:53 +0000 (02:52 +0000)
lib/statslib.php

index 691ba7b38ea4722a2ee670006f0d7a93193d3965..00de7537a833f1d3d785856e8fb5089cfd01146d 100644 (file)
@@ -1171,9 +1171,9 @@ function stats_get_parameters($time,$report,$courseid,$mode,$roleid=0) {
         $param->sql = 'SELECT activity.courseid, activity.all_activity AS line1, enrolments.highest_enrolments AS line2,
                         activity.all_activity / enrolments.highest_enrolments as line3
                        FROM (
-                            SELECT courseid, (stat1+stat2) AS all_activity
+                            SELECT courseid, sum(stat1+stat2) AS all_activity
                               FROM {stats_'.$param->table.'}
-                             WHERE stattype=\'activity\' AND timeend >= '.$param->timeafter.' AND roleid = 0
+                             WHERE stattype=\'activity\' AND timeend >= '.$param->timeafter.' AND roleid = 0 GROUP BY courseid
                        ) activity
                        INNER JOIN
                             (