MDL-19349 upgrade_plugin_savepoint() added 2 suggestions

diff --git a/lib/upgradelib.php b/lib/upgradelib.php
index 99e0332e30c8ec92a213ba6c5f7597493761269c..518a86a22f84b1c152f9b8776bf09dcc55473b99 100644 (file)
--- a/lib/upgradelib.php
+++ b/lib/upgradelib.php
@@ -261,6 +261,9 @@ function upgrade_plugin_savepoint($result, $version, $type, $dir, $allowabort=tr
         throw new upgrade_exception("$type/$dir", $version);
     }
 
+    /// TODO: Check that $type is a correct type - based on get_plugin_types()
+    /// TODO: Check that $dir (that perhaps should be named $name) is an existing plugin
+
     $fullname = $type.'_'.$dir;
     $component = $type.'/'.$dir;
 
@@ -1145,4 +1148,4 @@ function core_tables_exist() {
         }
         return true;
     }        
-}
\ No newline at end of file
+}