MDL-15834 portfolio supported_formats doesn't need to be abstract

diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
index 84863c1fb16b7bde9ee05f887617ee05ee993286..d5437e80f7cc1beaaaf407b0b88f08cb340e7ae0 100644 (file)
--- a/lib/portfoliolib.php
+++ b/lib/portfoliolib.php
@@ -705,7 +705,9 @@ abstract class portfolio_caller_base {
     *
     * @return array list of formats
     */
-    public abstract static function supported_formats();
+    public static function supported_formats() {
+        return array(PORTFOLIO_FORMAT_FILE);
+    }
 
     /**
     * this is the "return to where you were" url
@@ -810,7 +812,9 @@ abstract class portfolio_plugin_base {
     *
     * @return array list of formats
     */
-    public abstract static function supported_formats();
+    public static function supported_formats() {
+        return array(PORTFOLIO_FORMAT_FILE);
+    }
 
 
     /**

diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php
index c1dae2afb48103b2cd413afd7f8b7f47beab2edb..6e81b15ba2e7e0e05a10e135cb102e2770c9af1f 100644 (file)
--- a/mod/assignment/lib.php
+++ b/mod/assignment/lib.php
@@ -3162,11 +3162,6 @@ class assignment_portfolio_caller extends portfolio_module_caller_base {
         return backup_copy_file($filearea, $tempdir);
     }
 
-    public static function supported_formats() {
-        return array(PORTFOLIO_FORMAT_FILE);
-    }
-
-
     public function expected_time() {
         return PORTFOLIO_TIME_MODERATE; // @TODO check uploaded file size
     }

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index 292ed5b39750a5ac32bd7e6bcec28f4d05b1dc78..c238ed39101e4f826c1723cc598d8c83774df077 100644 (file)
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -7069,10 +7069,6 @@ class forum_portfolio_caller extends portfolio_module_caller_base {
         // @todo see MDL-15758
     }
 
-    static function supported_formats() {
-        return array(PORTFOLIO_FORMAT_FILE);
-    }
-
     function expected_time() {
         // @todo check for attachment size
         return PORTFOLIO_TIME_LOW;

diff --git a/mod/resource/lib.php b/mod/resource/lib.php
index b5e8c93851b309f3ae976c59fbf6eb636c753591..02d2dc71b2fde996e557b5e59eedc2783117dfee 100644 (file)
--- a/mod/resource/lib.php
+++ b/mod/resource/lib.php
@@ -738,10 +738,6 @@ class resource_portfolio_caller extends portfolio_module_caller_base {
         return $this->resource->portfolio_prepare_package($tempdir);
     }
 
-    public static function supported_formats() {
-        return array(PORTFOLIO_FORMAT_FILE);
-    }
-
     public function check_permissions() {
         return true;
     }

diff --git a/portfolio/type/boxnet/lib.php b/portfolio/type/boxnet/lib.php
index 7eca2b4390487d43885140cadfa042afaedf836d..ebcf5482585b303926a7f72435d3c4d2bfae9e4a 100644 (file)
--- a/portfolio/type/boxnet/lib.php
+++ b/portfolio/type/boxnet/lib.php
@@ -10,10 +10,6 @@ class portfolio_plugin_boxnet extends portfolio_plugin_base {
     private $workdir;
     private $folders;
 
-    public static function supported_formats() {
-        return array(PORTFOLIO_FORMAT_FILE);
-    }
-
     public function prepare_package($tempdir) {
         $this->workdir = $tempdir;
         return true; // don't do anything else for this plugin, we want to send all files as they are.

diff --git a/portfolio/type/download/lib.php b/portfolio/type/download/lib.php
index 7775d75a647f6ebc6682f4f12dd1be259a3ba1b2..e37c1aa9e4e9869c272ed6d54b4b59dd731cf214 100644 (file)
--- a/portfolio/type/download/lib.php
+++ b/portfolio/type/download/lib.php
@@ -7,11 +7,6 @@ class portfolio_plugin_download extends portfolio_plugin_base {
     protected $zipfile;
     protected $exportconfig;
 
-    public static function supported_formats() {
-        return array(PORTFOLIO_FORMAT_FILE);
-        // @todo more later, like moodle backup for example
-    }
-
     public static function allows_multiple() {
         return false;
     }