If an error occures, id returns 0.

The user, who will be sent email, may be confused for $record->id=0.
Merged from 16stable.

diff --git a/enrol/authorize/authorizenetlib.php b/enrol/authorize/authorizenetlib.php
index a1b4c5f2e3897cb1e4d469d931faf7bfe8080d96..d3b83ab597670034cc848aef59c9291aa39a8129 100644 (file)
--- a/enrol/authorize/authorizenetlib.php
+++ b/enrol/authorize/authorizenetlib.php
@@ -331,7 +331,7 @@ function authorize_action(&$order, &$message, &$extra, $action=AN_ACTION_NONE, $
                 $extra->transid = $transid;
                 $extra->settletime = authorize_getsettletime(time());
                 unset($extra->sum); // this is not used in refunds table.
-                if (! $extra->id = insert_record('enrol_authorize_refunds', $extra)) {
+                if (! insert_record('enrol_authorize_refunds', $extra)) {
                     email_to_admin("Error while trying to insert data " .
                     "into table enrol_authorize_refunds. Please add manually this record:", $extra);
                 }