Force download checkbox is not initialized properly, credit goes to skodak. MDL-14010...

diff --git a/mod/resource/type/file/resource.class.php b/mod/resource/type/file/resource.class.php
index 5fffca58b7ea6e2aa9f2e063a6d58996c9af59c6..fdfe53fd0cfa3e5f6746577b5f6516c7baac539a 100644 (file)
--- a/mod/resource/type/file/resource.class.php
+++ b/mod/resource/type/file/resource.class.php
@@ -131,7 +131,10 @@ class resource_file extends resource_base {
         global $RESOURCE_WINDOW_OPTIONS;
         $alloptions = $RESOURCE_WINDOW_OPTIONS;
 
-        if ($resource->windowpopup) {
+        if ($resource->forcedownload) {
+            $resource->options = 'forcedownload';
+
+        } else if ($resource->windowpopup) {
             $optionlist = array();
             foreach ($alloptions as $option) {
                 $optionlist[] = $option."=".$resource->$option;
@@ -162,10 +165,6 @@ class resource_file extends resource_base {
             unset($resource->$parametername);
         }
 
-        if ($resource->forcedownload) {
-            $resource->options = 'forcedownload';
-        }
-
         $resource->alltext = implode(',', $optionlist);
     }
 
@@ -664,7 +663,10 @@ class resource_file extends resource_base {
 
     function setup_preprocessing(&$defaults){
 
-        if (!isset($defaults['popup'])) {
+        if (isset($defaults['options']) and $defaults['options'] === 'forcedownload') {
+            $defaults['forcedownload'] = 1;
+
+        } else if (!isset($defaults['popup'])) {
             // use form defaults
 
         } else if (!empty($defaults['popup'])) {