Semantically it's better if quiz_get_best_grade returns NULL

if there is no such grade.

diff --git a/mod/quiz/index.php b/mod/quiz/index.php
index 3f2eb4df36b0249c900a586df75895b950a627ae..a6440bc1afe23b9a3ae05efa9a90f1f7405afa42 100644 (file)
--- a/mod/quiz/index.php
+++ b/mod/quiz/index.php
@@ -107,7 +107,7 @@
                 $gradecol = "";
             }
         } else { 
-            if ($bestgrade === "" or $quiz->grade == 0) {
+            if ($bestgrade === NULL || $quiz->grade == 0) {
                 $gradecol = "";
             } else {
                 $gradecol = "$bestgrade / $quiz->grade";

diff --git a/mod/quiz/locallib.php b/mod/quiz/locallib.php
index e3d4540bb5f44eb06b4fa607d369522ac8fd8174..e78b5fdb38a4f141b26c1961e5dc3c5e859861dc 100644 (file)
--- a/mod/quiz/locallib.php
+++ b/mod/quiz/locallib.php
@@ -1440,11 +1440,11 @@ function quiz_get_user_attempts_string($quiz, $attempts, $bestgrade) {
 
 function quiz_get_best_grade($quizid, $userid) {
 /// Get the best current grade for a particular user in a quiz
-    if (!$grade = get_record("quiz_grades", "quiz", $quizid, "userid", $userid)) {
-        return "";
+    if (!$grade = get_record('quiz_grades', 'quiz', $quizid, 'userid', $userid)) {
+        return NULL;
     }
 
-    return (round($grade->grade,0));
+    return (round($grade->grade));
 }
 
 function quiz_save_best_grade($quiz, $userid) {