MDL-13117 - course info was unavailable to students. There was broken logic...

course_parent_visible() always returns true if $CFG->allowvisiblecoursesinhiddencategories
is true,

diff --git a/course/info.php b/course/info.php
index 27354c9eef4df8b6f62881ea25eaa8d10e5636e6..e5ecf3304f033ef73d3f7c000241f01e9608bb52 100644 (file)
--- a/course/info.php
+++ b/course/info.php
@@ -29,7 +29,7 @@
     }
 
     $context = get_context_instance(CONTEXT_COURSE, $course->id);
-    if ((!(course_parent_visible($course) && $CFG->allowvisiblecoursesinhiddencategories) || (! $course->visible)) && !has_capability('moodle/course:viewhiddencourses', $context)) {
+    if ((!course_parent_visible($course) || (! $course->visible)) && !has_capability('moodle/course:viewhiddencourses', $context)) {
         error(get_string('coursehidden'), $CFG->wwwroot .'/'); 
     }