Cleaner saving of grader report prefs

diff --git a/grade/report/grader/preferences.php b/grade/report/grader/preferences.php
index 9fa9e034bcb1e7cfa6c0b921df821dc8bc91a09b..04e6a30528221869919e276224f78619c7e37831 100644 (file)
--- a/grade/report/grader/preferences.php
+++ b/grade/report/grader/preferences.php
@@ -43,19 +43,15 @@ require_capability('gradereport/grader:view', $context);
 
 // If data submitted, then process and store.
 if ($data = data_submitted()) {
-
     foreach ($data as $preference => $value) {
-        switch ($preference) {
-            case 'persistflt':
-                set_user_preference('calendar_persistflt', intval($value));
-                break;
-            default:
-                if ($value == GRADE_REPORT_PREFERENCE_DEFAULT || strlen($value) == 0) {
-                    unset_user_preference($preference);
-                } else {
-                    set_user_preference($preference, $value);
-                }
-                break;
+        if (substr($preference, 0, 6) !== 'grade_') {
+            continue;
+        }
+
+        if ($value == GRADE_REPORT_PREFERENCE_DEFAULT || strlen($value) == 0) {
+            unset_user_preference($preference);
+        } else {
+            set_user_preference($preference, $value);
         }
     }