MDL-15000 "Moodle url method remove_params doesn't actually remove anything" Fixed.

diff --git a/lib/weblib.php b/lib/weblib.php
index 621f40ace3babaaaf61f7914fa686926e193b35f..7b06ee782a3c25f7f1f321804546a20547adc6a2 100644 (file)
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -358,8 +358,8 @@ class moodle_url {
     function remove_params(){
         if ($thisargs = func_get_args()){
             foreach ($thisargs as $arg){
-                if (isset($this->params->$arg)){
-                    unset($this->params->$arg);
+                if (isset($this->params[$arg])){
+                    unset($this->params[$arg]);
                 }
             }
         } else { // no args