notice() should be allowed at install/upgrade. It stops the whole

process without need to do it. Changed to notify().

Thanks to one "orphan" forum in moodle.org (234) we detected this.

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index 3570396c9e9afdc366a5e83bb7bf1a7c1f319942..13bd5c49427da4f19936fa2b1c59021e5b33946c 100644 (file)
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -4258,8 +4258,8 @@ function forum_convert_to_roles($forum, $forummodid, $studentroles=array(), $gue
         if (empty($cmid)) {
             // We were not given the course_module id. Try to find it.
             if (!$cm = get_coursemodule_from_instance('forum', $forum->id)) {
-                notice('Could not get the course module for the forum');
-                continue;
+                notify('Could not get the course module for the forum');
+                return false;
             } else {
                 $cmid = $cm->id;
             }