security MDL-18807 Changed language strings: Thanks for the new strings Helen

diff --git a/admin/index.php b/admin/index.php
index 513b17903a166cd9022a2172567a1f7743ef8988..ed3727e83cb17bdf118d149e37d3bcc1dc64bf6a 100644 (file)
--- a/admin/index.php
+++ b/admin/index.php
@@ -369,7 +369,7 @@ if ($insecuredataroot == INSECURE_DATAROOT_WARNING) {
 }
 
 if (empty($CFG->passwordsaltmain)) {
-    print_box(get_string('upgrade197notice', 'admin')."\n".get_string('upgrade197salt', 'admin'));
+    print_box(get_string('upgrade197notice', 'admin')."\n".get_string('upgrade197salt', 'admin', get_docs_url('report/security/report_security_check_passwordsaltmain')));
 }
 
 if (defined('WARN_DISPLAY_ERRORS_ENABLED')) {

diff --git a/admin/report/security/lib.php b/admin/report/security/lib.php
index 16a9232f23b476c118f6e8e6881fbc49665355bd..79e1cd8660773184e1c15e42824056a8f658bf2f 100644 (file)
--- a/admin/report/security/lib.php
+++ b/admin/report/security/lib.php
@@ -498,7 +498,7 @@ function report_security_check_passwordsaltmain($detailed=false) {
     }
 
     if ($detailed) {
-        $result->details = get_string('check_passwordsaltmain_details', 'report_security');
+        $result->details = get_string('check_passwordsaltmain_details', 'report_security', get_docs_url('report/security/report_security_check_passwordsaltmain'));
     }
 
     return $result;

diff --git a/lang/en_utf8/admin.php b/lang/en_utf8/admin.php
index b21b2fbe3590c5ed9c014621746283722d671d17..4042dcc6504d7d44e058ae619d9b0139a081dc8f 100644 (file)
--- a/lang/en_utf8/admin.php
+++ b/lang/en_utf8/admin.php
@@ -886,8 +886,7 @@ $string['upgrade197notice'] = '<p>Moodle 1.9.7 contains a number of security fix
 As a result some of your settings and permissions relating to backups may have changed.<br />
 Please see the <a href=\'http://docs.moodle.org/en/Moodle_1.9.7_release_notes\' target=\'_blank\'>Moodle 1.9.7 release</a> notes for full details.</p>';
 $string['upgrade197noticesubject'] = 'Moodle 1.9.7 upgrade security notices';
-$string['upgrade197salt'] = 'It is also now strongly recommended that you set a password salt to greatly reduce the risk of password theft.<br />
-Please refer to the Moodle security report for more information on this topic. The security report can be accessed by logging into your site as an administrator and go to Site Administration - Security - Site policies';
+$string['upgrade197salt'] = 'It is also now strongly recommended that you set a password salt to greatly reduce the risk of password theft.<br />Please refer to the <a href=\"$a\" target=\"_blank\">password salting documentation</a> for details.</a>';
 $string['upgradeerror'] = 'Unknown error upgrading $a->plugin to version $a->version, can not continue.';
 $string['upgradeforumread'] = 'A new feature has been added in Moodle 1.5 to track read/unread forum posts.<br />To use this functionality you need to <a href=\"$a\">update your tables</a>.';
 $string['upgradeforumreadinfo'] = 'A new feature has been added in Moodle 1.5 to track read/unread forum posts.  To use this functionality you need to update your tables with all the tracking information for existing posts.  Depending on the size of your site this can take a long time (hours) and can be quite taxing on the database, so it\'s best to do it during a quiet period.  However, your site will continue functioning during this upgrade and users won\'t be affected.  Once you start this process you should let it finish (keep your browser window open).  However, if you stop the process by closing the window: don\'t worry, you can start over.<br /><br />Do you want to start the upgrading process now?';

diff --git a/lang/en_utf8/report_security.php b/lang/en_utf8/report_security.php
index 5acd90fbf6265244183593c14f73f862c1a14b98..40baefb2f243141174fb3091c3578833899fccb9 100644 (file)
--- a/lang/en_utf8/report_security.php
+++ b/lang/en_utf8/report_security.php
@@ -123,9 +123,11 @@ $string['check_passwordsaltmain_name'] = 'Password salt';
 $string['check_passwordsaltmain_warning'] = 'No password salt has been set';
 $string['check_passwordsaltmain_ok'] = 'Password salt is OK';
 $string['check_passwordsaltmain_weak'] = 'Password salt is weak';
-$string['check_passwordsaltmain_details'] = '<p>It is strongly recommended that a password salt is set as it greatly reduces the risk of password theft.<br />To set a password salt add the following to your config.php file.</p><code>\$CFG->passwordsaltmain = \'a_very_long_random_string_of_characters#@6&*1\';</code>
-<p>The random string of characters should be a mix of letters, numbers and other characters.</p>
-<p>When changing main salt make sure that you include the old value in config.php, there may be 20 alternative salts. Without the old value in alternative salts list users will not be able to login and will have to use password reset.<br /><code>\$CFG->passwordsaltalt1 = \'previous_main_salt\';</code><br /></p>';
+$string['check_passwordsaltmain_details'] = '<p>Setting a password salt greatly reduces the risk of password theft.</p>
+<p>To set a password salt, add the following line to your config.php file:</p>
+<code>\$CFG->passwordsaltmain = \'some long random string here with lots of characters\';</code>
+<p>The random string of characters should be a mix of letters, numbers and other characters. A string length of at least 40 characters is recommended.</p>
+<p>Please refer to the <a href=\"$a\" target=\"_blank\">password salting documentation</a> if you wish to change the password salt. Once set, do NOT delete your password salt otherwise you will no longer be able to login to your site!</p>';
 
 $string['check_riskadmin_detailsok'] = '<p>Please verify the following list of system administrators:</p>$a';
 $string['check_riskadmin_detailswarning'] = '<p>Please verify the following list of system administrators:</p>$a->admins