MDL-9432 - Forgot to return success/failure in two places.

diff --git a/question/type/match/questiontype.php b/question/type/match/questiontype.php
index 1b243b66ca1aa45e6b5ef65924cd36eb7d1d19d6..7a8b2625d6434c13da7c32e445ecb01f841b7e04 100644 (file)
--- a/question/type/match/questiontype.php
+++ b/question/type/match/questiontype.php
@@ -614,6 +614,8 @@ class question_match_qtype extends default_questiontype {
      * @return bool success or failure.
      */ 
     function decode_content_links_caller($questionids, $restore, &$i) {
+        $status = true;
+
         // Decode links in the question_match_sub table.
         if ($subquestions = get_records_list('question_match_sub', 'question',
                 implode(',',  $questionids), '', 'id, questiontext')) {
@@ -637,6 +639,8 @@ class question_match_qtype extends default_questiontype {
                 }
             }
         }
+
+        return $status;
     }
 }
 //// END OF CLASS ////

diff --git a/question/type/multichoice/questiontype.php b/question/type/multichoice/questiontype.php
index 5697efedafdc63d831b772a1d9824fa67603e465..18af0e19bef8c812b87a84df5ab7181d3ad59327 100644 (file)
--- a/question/type/multichoice/questiontype.php
+++ b/question/type/multichoice/questiontype.php
@@ -558,6 +558,8 @@ class question_multichoice_qtype extends default_questiontype {
      * @return bool success or failure.
      */ 
     function decode_content_links_caller($questionids, $restore, &$i) {
+        $status = true;
+
         // Decode links in the question_multichoice table.
         if ($multichoices = get_records_list('question_multichoice', 'question',
                 implode(',',  $questionids), '', 'id, correctfeedback, partiallycorrectfeedback, incorrectfeedback')) {
@@ -587,6 +589,8 @@ class question_multichoice_qtype extends default_questiontype {
                 }
             }
         }
+
+        return $status;
     }
 
     /**