Fix one wrong test. To get defaults applied, new column must be not null.

diff --git a/lib/ddl/simpletest/testddl.php b/lib/ddl/simpletest/testddl.php
index 08adaf51d4ca4c6ed96d5a58d396bbcf0526701d..e70340a8a66386eaec093624ef7340efc9c1a2fa 100755 (executable)
--- a/lib/ddl/simpletest/testddl.php
+++ b/lib/ddl/simpletest/testddl.php
@@ -475,14 +475,14 @@ class ddl_test extends UnitTestCase {
 
         /// add one char field and check it
         $field = new xmldb_field('onechar');
-        $field->set_attributes(XMLDB_TYPE_CHAR, '25', XMLDB_UNSIGNED, null, null, 'Nice dflt!');
+        $field->set_attributes(XMLDB_TYPE_CHAR, '25', XMLDB_UNSIGNED, XMLDB_NOTNULL, null, 'Nice dflt!');
         $dbman->add_field($table, $field);
         $this->assertTrue($dbman->field_exists($table, 'onechar'));
         $columns = $DB->get_columns('test_table1');
         $this->assertEqual($columns['onechar']->name         ,'onechar');
         $this->assertEqual($columns['onechar']->max_length   , 25);
         $this->assertEqual($columns['onechar']->scale        , null);
-        $this->assertEqual($columns['onechar']->not_null     , false);
+        $this->assertEqual($columns['onechar']->not_null     , true);
         $this->assertEqual($columns['onechar']->primary_key  , false);
         $this->assertEqual($columns['onechar']->binary       , false);
         $this->assertEqual($columns['onechar']->has_default  , true);
@@ -700,7 +700,7 @@ class ddl_test extends UnitTestCase {
         $this->assertEqual($columns['anothernumber']->meta_type, 'I');
         //TODO: chek the rest of attributes
 
-        // change the column from number to text
+        // change the column from integer to text
         $field = new xmldb_field('anothernumber');
         $field->set_attributes(XMLDB_TYPE_TEXT, 'big', null, XMLDB_NOTNULL, null, null);
         $dbman->change_field_type($table, $field);