Cron tidy-ups

diff --git a/admin/cron.php b/admin/cron.php
index 0214afd1a29d42a021b0913acf7c9b8c96afc5a9..fe9157a84233024ad130704676aaa093a5a8c770 100644 (file)
--- a/admin/cron.php
+++ b/admin/cron.php
@@ -41,12 +41,15 @@
 
     // Unsubscribe users who haven't logged in for $CFG->longtimenosee
 
-    if ($CFG->longtimenosee) {
+    if ($CFG->longtimenosee) { // value in days
         $cutofftime = time() - ($CFG->longtimenosee * 3600 * 24);
-        if ($users = get_records_sql("SELECT * FROM user WHERE lastaccess > 0 AND lastaccess < '$cutofftime'")) {
+        if ($users = get_records_sql("SELECT * FROM user 
+                                       WHERE lastaccess > '0' AND 
+                                             lastaccess < '$cutofftime'")) {
             foreach ($users as $user) {
-                delete_records("user_students", "user", $user->id);
-                echo "Deleted student enrolment for $user->firsname $user->lastname ($user->id)\n";
+                if (delete_records("user_students", "user", $user->id)) {
+                    echo "Deleted student enrolment for $user->firstname $user->lastname ($user->id)\n";
+                }
             }
         }
     }
@@ -54,10 +57,14 @@
     // Delete users who haven't confirmed within seven days
 
     $cutofftime = time() - (7 * 24 * 3600);
-    if ($users = get_records_sql("SELECT * FROM user WHERE confirmed = 0 AND firstaccess > 0 AND firstaccess < '$cutofftime'")) {
+    if ($users = get_records_sql("SELECT * FROM user 
+                                  WHERE confirmed = '0' AND 
+                                        firstaccess > '0' AND 
+                                        firstaccess < '$cutofftime'")) {
         foreach ($users as $user) {
-            delete_records("user", "id", $user->id);
-            echo "Deleted unconfirmed user for $user->firsname $user->lastname ($user->id)\n";
+            if (delete_records("user", "id", $user->id)) {
+                echo "Deleted unconfirmed user for $user->firsname $user->lastname ($user->id)\n";
+            }
         }
     }
 

diff --git a/mod/journal/lib.php b/mod/journal/lib.php
index c7fd845b6f2b01313a37027c2b12eb38284ea072..b48bd16858ffe25ed9e3dc713994b6ea2e3541a3 100644 (file)
--- a/mod/journal/lib.php
+++ b/mod/journal/lib.php
@@ -53,8 +53,6 @@ function journal_cron () {
 
     global $CFG;
 
-    echo "Processing journals...\n";
-
     $cutofftime = time() - $CFG->maxeditingtime;
 
     if ($entries = get_records_sql("SELECT e.*, j.course, j.name