better validation of null answers MDL-8475

diff --git a/question/type/numerical/edit_numerical_form.php b/question/type/numerical/edit_numerical_form.php
index dc61ee19e8756b1352e5df8d8d8354e5afd60b48..62b7923ac9e6e7e6c89ee9f98c0c9858bf68b31d 100644 (file)
--- a/question/type/numerical/edit_numerical_form.php
+++ b/question/type/numerical/edit_numerical_form.php
@@ -124,6 +124,14 @@ class question_edit_numerical_form extends question_edit_form {
                 if ($data['fraction'][$key] == 1) {
                     $maxgrade = true;
                 }
+            } else {
+                if ($data['fraction'][$key] !=0 || trim($data['feedback'][$key]) != ''){                
+                    $errors["answer[$key]"] = get_string('answermustbenumberorstar', 'qtype_numerical');
+                    $answercount++;
+                    if (trim($data['feedback'][$key]) != ''){
+                        $errors["feedback[$key]"]=get_string('feedback','quiz').'='.htmlspecialchars(trim($data['feedback'][$key]));
+                    }
+                }
             }
         }
         if ($answercount==0){