MDL-14588 - Prevent error message when calling function with null variable (merge...

diff --git a/question/backuplib.php b/question/backuplib.php
index 4588681bd029221931a0b55350a69a33241148e8..aee1cb568cc9a469d17b574a8df814dcb2c83f4d 100644 (file)
--- a/question/backuplib.php
+++ b/question/backuplib.php
@@ -459,14 +459,17 @@
     function question_insert_c_and_q_ids_for_module($backup_unique_code, $course, $modulename, $instances){
         global $CFG;
         $status = true;
-            // using 'dummykeyname' in sql because otherwise get_records_sql_menu returns an error
+        // using 'dummykeyname' in sql because otherwise get_records_sql_menu returns an error
         // if two key names are the same.
-        $cmcontexts = get_records_sql_menu("SELECT c.id, c.id AS dummykeyname FROM {$CFG->prefix}modules m,
+        $cmcontexts = array();
+        if(!empty($instances)) {
+            $cmcontexts = get_records_sql_menu("SELECT c.id, c.id AS dummykeyname FROM {$CFG->prefix}modules m,
                                                         {$CFG->prefix}course_modules cm,
                                                         {$CFG->prefix}context c
                                WHERE m.name = '$modulename' AND m.id = cm.module AND cm.id = c.instanceid
                                     AND c.contextlevel = ".CONTEXT_MODULE." AND cm.course = $course
                                     AND cm.instance IN (".implode(',',array_keys($instances)).")");
+        }
                                     
         if ($cmcontexts){
             $status = $status && execute_sql("INSERT INTO {$CFG->prefix}backup_ids