MDL-12886 fixed TODOs

diff --git a/webservice/lib.php b/webservice/lib.php
index a0d6e2323dd507fdff0786ad6dcb8dbc876eac39..23fe69f62c4996df4c05390fe57946546fc3e111 100644 (file)
--- a/webservice/lib.php
+++ b/webservice/lib.php
@@ -148,7 +148,7 @@ abstract class webservice_server implements webservice_server_interface {
             }
 
             if (!$auth->user_login_webservice($this->username, $this->password)) {
-                // TODO: log failed login attempts
+                // TODO: MDL-12886 log failed login attempts
                 throw new webservice_access_exception('Wrong username or password');
             }
 
@@ -156,7 +156,7 @@ abstract class webservice_server implements webservice_server_interface {
 
         } else {
             if (!$token = $DB->get_record('external_tokens', array('token'=>$this->token, 'tokentype'=>EXTERNAL_TOKEN_PERMANENT))) {
-                // TODO: log failed login attempts
+                // TODO: MDL-12886 log failed login attempts
                 throw new webservice_access_exception('Invalid token');
             }
 

diff --git a/webservice/testclient.php b/webservice/testclient.php
index ee5269b6515c9bd2e4fa183a59a1b0df01a6a3a6..e652e1e047474c4d3824633cc8576e2a9e893724 100644 (file)
--- a/webservice/testclient.php
+++ b/webservice/testclient.php
@@ -34,7 +34,7 @@ $protocol = optional_param('protocol', '', PARAM_SAFEDIR);
 $PAGE->set_url('webservice/testclient.php');
 
 require_login();
-require_capability('moodle/site:config', get_context_instance(CONTEXT_SYSTEM)); // TODO: do we need some new capability?
+require_capability('moodle/site:config', get_context_instance(CONTEXT_SYSTEM));
 
 // list of all available functions for testing
 $allfunctions = $DB->get_records('external_functions', array(), 'name ASC');