If we create a directory, then chmod it to protect the contents.

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index e45d4fa638b9f0350b5606dba24397381fac3c8c..cf5708e4fd890a73af7f33142eb89cba53e2eeb7 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -751,11 +751,13 @@ function make_upload_directory($directory) {
     global $CFG;
 
     $currdir = $CFG->dataroot;
+
     if (!file_exists($currdir)) {
         if (! mkdir($currdir, 0750)) {
             notify("ERROR: You need to create the directory $currdir with web server write access");
             return false;
         }
+        chmod($currdir,0750);
     }
 
     $dirarray = explode("/", $directory);
@@ -767,6 +769,7 @@ function make_upload_directory($directory) {
                 notify("ERROR: Could not find or create a directory ($currdir)");
                 return false;
             }
+            chmod($currdir,0750);
         }
     }