preventing notifications by using isset() unsparingly (i.e. small bug fixes)

diff --git a/blocks/admin_bookmarks/block_admin_bookmarks.php b/blocks/admin_bookmarks/block_admin_bookmarks.php
index b49e54c62023b2f45829b3b6fb5e67c8c96507bb..f76ebe07fb5234012457b4e66223084e2e1e5533 100644 (file)
--- a/blocks/admin_bookmarks/block_admin_bookmarks.php
+++ b/blocks/admin_bookmarks/block_admin_bookmarks.php
@@ -32,6 +32,7 @@ class block_admin_bookmarks extends block_base {
         }
 
         $this->content = new stdClass;
+        $this->content->text = '';
                if (isset($USER->preference['admin_bookmarks'])) {
             $bookmarks = explode(',',$USER->preference['admin_bookmarks']);
                        // hmm... just a liiitle (potentially) processor-intensive

diff --git a/blocks/admin_bookmarks/create.php b/blocks/admin_bookmarks/create.php
index de96060655e1d722e601fc93d455ee93def3d22e..2d2e3df4f9eecbd4ca9ce5ae007327db82f8c4f1 100644 (file)
--- a/blocks/admin_bookmarks/create.php
+++ b/blocks/admin_bookmarks/create.php
@@ -6,7 +6,7 @@ require_once($CFG->dirroot . '/admin/adminlib.php');
 
 if ($section = optional_param('section', '', PARAM_ALPHAEXT)) {
 
-    if ($USER->preference['admin_bookmarks']) {
+    if (isset($USER->preference['admin_bookmarks'])) {
         $bookmarks = explode(',',$USER->preference['admin_bookmarks']);
                
         if (in_array($section, $bookmarks)) {

diff --git a/blocks/admin_bookmarks/delete.php b/blocks/admin_bookmarks/delete.php
index d482d4de66701affdeb0ab48ff3ace594d09c109..e53f1f29cb998883b8dd3fd5ebfbc952fe4862fe 100644 (file)
--- a/blocks/admin_bookmarks/delete.php
+++ b/blocks/admin_bookmarks/delete.php
@@ -6,7 +6,7 @@ require_once($CFG->dirroot . '/admin/adminlib.php');
 
 if ($section = optional_param('section', '', PARAM_ALPHAEXT)) {
 
-    if ($USER->preference['admin_bookmarks']) {
+    if (isset($USER->preference['admin_bookmarks'])) {
 
         $bookmarks = explode(',', $USER->preference['admin_bookmarks']);