Messaging MDL-3321 Searching for empty string returns all messages

diff --git a/message/lib.php b/message/lib.php
index f25490167a6c1dcf53499345ff390bf7bfeac857..e8e16046a3c5807edffbe069bf7dbd7fe1225535 100644 (file)
--- a/message/lib.php
+++ b/message/lib.php
@@ -354,9 +354,13 @@ function message_print_search_results($frm) {
 
 
     /// search messages for keywords
-    } else if (!empty($frm->keywordssubmit) and !empty($frm->keywords)) {
+    } else if (!empty($frm->keywordssubmit)) {
         $keywordstring = clean_text(trim($frm->keywords));
-        $keywords = explode(' ', $keywordstring);
+        if ($keywordstring) {
+            $keywords = explode(' ', $keywordstring);
+        } else {
+            $keywords = array();
+        }
         $tome     = false;
         $fromme   = false;
         $courseid = 'none';
@@ -735,11 +739,12 @@ function message_search($searchterms, $fromme=true, $tome=true, $courseid='none'
     }
 
     if (empty($searchcond)) {
-        return array();
+        $searchcond = " m.fullmessage $LIKE :ss1";
+        $params['ss1'] = "%";
+    } else {
+        $searchcond = implode(" AND ", $searchcond);
     }
 
-    $searchcond = implode(" AND ", $searchcond);
-
 
     /// There are several possibilities
     /// 1. courseid = SITEID : The admin is searching messages by all users