Sorry, Petri, but we need to undo these changes, because:

  - they could break accounts in existing installations
  - strtolower can corrupt strings in multibyte languages

Is it really a problem that usernames are case sensitive on PostgreSQL?

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 5856d4bac4daf552ad4c49d1129e7a5c53e16764..9c73e183faf512d6fab8a4ed8caaa46eeb05b326 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -484,8 +484,6 @@ function create_user_record($username, $password) {
 /// Creates a bare-bones user record 
     global $REMOTE_ADDR, $CFG;
     
-    $username = strtolower($username);
-    
     if (function_exists(auth_get_userinfo)) {
         if ($newinfo = auth_get_userinfo($username)) {
             foreach ($newinfo as $key => $value){

diff --git a/user/edit.php b/user/edit.php
index 4f42084c2b582b34f2e1ef388a504173adc51ac7..4eb3c328a6c80ec7c42f966707456db5e76ba578 100644 (file)
--- a/user/edit.php
+++ b/user/edit.php
@@ -43,7 +43,6 @@
 /// If data submitted, then process and store.
 
        if ($usernew = data_submitted()) {
-        $usernew->username = strtolower($usernew->username);
         $usernew->firstname = strip_tags($usernew->firstname);
         $usernew->lastname  = strip_tags($usernew->lastname);