From: skodak Date: Sat, 7 Jun 2008 22:22:06 +0000 (+0000) Subject: MDL-15107 feedback dml conversion X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=0085fff8b2c99dcc773af5b7760d0a3336ffbc1e;p=moodle.git MDL-15107 feedback dml conversion --- diff --git a/mod/feedback/analysis.php b/mod/feedback/analysis.php index 12fb2e244d..74155c243b 100644 --- a/mod/feedback/analysis.php +++ b/mod/feedback/analysis.php @@ -31,11 +31,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -114,14 +114,14 @@ $completedscount = feedback_get_completeds_group_count($feedback, $mygroupid); //show the group, if available - if($mygroupid and $group = get_record('groups', 'id', $mygroupid)) { + if($mygroupid and $group = $DB->get_record('groups', array('id'=>$mygroupid))) { echo ''.get_string('group').': '.$group->name. '
'; } //show the count echo ''.get_string('completed_feedbacks', 'feedback').': '.$completedscount. '
'; // get the items of the feedback - $items = get_records_select('feedback_item', 'feedback = '. $feedback->id . ' AND hasvalue = 1', 'position'); + $items = $DB->get_records('feedback_item', array('feedback'=>$feedback->id, 'hasvalue'=>1), 'position'); //show the count if(is_array($items)){ echo ''.get_string('questions', 'feedback').': ' .sizeof($items). '
'; diff --git a/mod/feedback/analysis_course.php b/mod/feedback/analysis_course.php index fa2409e3d7..8901d48373 100644 --- a/mod/feedback/analysis_course.php +++ b/mod/feedback/analysis_course.php @@ -31,11 +31,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -88,7 +88,7 @@ echo ''.get_string('completed_feedbacks', 'feedback').': '.$completedscount. '
'; // get the items of the feedback - $items = get_records_select('feedback_item', 'feedback = '. $feedback->id . ' AND hasvalue = 1', 'position'); + $items = $DB->get_records('feedback_item', array('feedback'=>$feedback->id, 'hasvalue'=>1), 'position'); //show the count if(is_array($items)){ echo ''.get_string('questions', 'feedback').': ' .sizeof($items). '
'; @@ -104,14 +104,13 @@ if ($CFG->dbtype == 'postgres7') { $avgvalue = 'avg(cast (value as integer))'; } - if ($courses = get_records_sql ('select fv.course_id, c.shortname, '.$avgvalue.' as avgvalue '. - 'from '.$CFG->prefix.'feedback_value fv, '.$CFG->prefix.'course c, '. - $CFG->prefix.'feedback_item fi '. - 'where fv.course_id = c.id '. - 'and fi.id = fv.item and fi.typ = \''.$courseitemfiltertyp.'\' and fv.item = \''. - $courseitemfilter.'\' '. - 'group by course_id, shortname order by avgvalue desc')) { - $item = get_record('feedback_item', 'id', $courseitemfilter); + if ($courses = $DB->get_records_sql ("SELECT fv.course_id, c.shortname, $avgvalue AS avgvalue + FROM {feedback_value} fv, {course} c, {feedback_item} fi + WHERE fv.course_id = c.id AND fi.id = fv.item AND fi.typ = ? AND fv.item = ? + GROUP BY course_id, shortname + ORDER BY avgvalue desc", + array($courseitemfiltertyp, $courseitemfilter))) { + $item = $DB->get_record('feedback_item', array('id'=>$courseitemfilter)); echo ''.$item->name.''; echo ''; echo ''; diff --git a/mod/feedback/analysis_to_excel.php b/mod/feedback/analysis_to_excel.php index aaa68ff218..1dd558b2d0 100644 --- a/mod/feedback/analysis_to_excel.php +++ b/mod/feedback/analysis_to_excel.php @@ -21,11 +21,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -106,7 +106,7 @@ } //get the questions (item-names) - $items = get_records_select('feedback_item', 'feedback = '. $feedback->id . ' AND hasvalue = 1', 'position'); + $items = $DB->get_records('feedback_item', array('feedback'=>$feedback->id, 'hasvalue'=>1, 'position')); if(is_array($items)){ $rowOffset1++; $worksheet1->write_string($rowOffset1, 0, $fstring->questions.': '. strval(sizeof($items))); @@ -193,17 +193,17 @@ } function feedback_excelprint_detailed_items(&$worksheet, $completed, $items, $rowOffset) { - global $fstring; + global $DB, $fstring; if(!$items) return; $colOffset = 0; $courseid = 0; - $feedback = get_record('feedback', 'id', $completed->feedback); + $feedback = $DB->get_record('feedback', array('id'=>$completed->feedback)); //get the username //anonymous users are separated automatically because the userid in the completed is "0" $worksheet->setFormat(''); - if($user = get_record('user', 'id', $completed->userid)) { + if($user = $DB->get_record('user', array('id'=>$completed->userid))) { if ($completed->anonymous_response == FEEDBACK_ANONYMOUS_NO) { $worksheet->write_string($rowOffset, $colOffset, $user->idnumber); $colOffset++; @@ -229,7 +229,7 @@ $colOffset++; foreach($items as $item) { - $value = get_record('feedback_value', 'item', $item->id, 'completed', $completed->id); + $value = $DB->get_record('feedback_value', array('item'=>$item->id, 'completed'=>$completed->id)); $itemclass = 'feedback_item_'.$item->typ; $itemobj = new $itemclass(); @@ -248,7 +248,7 @@ } $worksheet->write_number($rowOffset, $colOffset, $courseid); $colOffset++; - if(isset($courseid) AND $course = get_record('course', 'id', $courseid)){ + if(isset($courseid) AND $course = $DB->get_record('course', array('id'=>$courseid))) { $worksheet->write_string($rowOffset, $colOffset, $course->shortname); } return $rowOffset + 1; diff --git a/mod/feedback/backuplib.php b/mod/feedback/backuplib.php index aabbbc9a45..2b56b9ec99 100644 --- a/mod/feedback/backuplib.php +++ b/mod/feedback/backuplib.php @@ -28,12 +28,12 @@ //This function executes all the backup procedure about this mod function feedback_backup_mods($bf,$preferences) { - global $CFG; + global $CFG, $DB; $status = true; //Iterate over feedback table - $feedbacks = get_records ("feedback","course",$preferences->backup_course,"id"); + $feedbacks = $DB->get_records ("feedback", array("course"=>$preferences->backup_course), "id"); if ($feedbacks) { foreach ($feedbacks as $feedback) { if (backup_mod_selected($preferences,'feedback',$feedback->id)) { @@ -45,10 +45,10 @@ } function feedback_backup_one_mod($bf,$preferences,$feedback) { - global $CFG; + global $CFG, $DB; if (is_numeric($feedback)) { - $feedback = get_record('feedback','id',$feedback); + $feedback = $DB->get_record('feedback', array('id'=>$feedback)); } $status = true; @@ -79,9 +79,10 @@ } function feedback_backup_data($bf, $preferences, $feedbackid) { - global $CFG; + global $CFG, $DB; + $status = true; - $feedbackitems = get_records('feedback_item', 'feedback', $feedbackid); + $feedbackitems = $DB->get_records('feedback_item', array('feedback'=>$feedbackid)); if(function_exists('backup_userdata_selected')) { //compatibility-hack for moodle 1.5.x $backup_userdata = backup_userdata_selected($preferences,'feedback',$feedbackid); }else { @@ -104,7 +105,7 @@ if ($backup_userdata) { //backup the values of items - $feedbackvalues = get_records('feedback_value', 'item', $feedbackitem->id); + $feedbackvalues = $DB->get_records('feedback_value', array('item'=>$feedbackitem->id)); if($feedbackvalues) { $status =fwrite ($bf,start_tag("FBVALUES",6,true)); foreach($feedbackvalues as $feedbackvalue) { @@ -130,7 +131,7 @@ if($backup_userdata) { //backup of feedback-completeds - $feedbackcompleteds = get_records('feedback_completed', 'feedback', $feedbackid); + $feedbackcompleteds = $DB->get_records('feedback_completed', array('feedback'=>$feedbackid)); if($feedbackcompleteds) { fwrite ($bf,start_tag("COMPLETEDS",4,true)); foreach ($feedbackcompleteds as $feedbackcompleted) { @@ -151,7 +152,7 @@ } //backup of tracking-data - $feedbacktrackings = get_records('feedback_tracking', 'feedback', $feedbackid); + $feedbacktrackings = $DB->get_records('feedback_tracking', array('feedback'=>$feedbackid)); if($feedbacktrackings) { fwrite ($bf,start_tag("TRACKINGS",4,true)); foreach ($feedbacktrackings as $feedbacktracking) { @@ -175,9 +176,10 @@ function feedback_backup_template_data($bf, $templateid, $userinfo) { - global $CFG; + global $CFG, $DB; + $status = true; - $templateitems = get_records('feedback_item', 'template', $templateid); + $templateitems = $DB->get_records('feedback_item', array('template'=>$templateid)); if ($templateitems) { $status =fwrite ($bf,start_tag("ITEMS",5,true)); @@ -228,6 +230,8 @@ ////Return an array of info (name,value) function feedback_check_backup_mods_instances($instance,$backup_unique_code) { + global $DB; + //First the course data $info[$instance->id.'0'][0] = ''.$instance->name.''; $info[$instance->id.'0'][1] = ''; @@ -235,7 +239,7 @@ //Now, if requested, the user_data if (!empty($instance->userdata)) { $info[$instance->id.'1'][0] = get_string("responses","feedback"); - if ($responses_count = count_records ('feedback_completed', 'feedback', $instance->id)) { + if ($responses_count = $DB->count_records ('feedback_completed', array('feedback'=>$instance->id))) { $info[$instance->id.'1'][1] = $responses_count; } else { $info[$instance->id.'1'][1] = 0; @@ -251,18 +255,20 @@ //Returns an array of feedbacks ids function feedback_count ($course) { - global $CFG; - return count_records('feedback', 'course', $course); + global $DB; + + return $DB->count_records('feedback', array('course'=>$course)); } function feedback_completed_count($course) { - global $CFG; + global $DB; + $count = 0; //get all feedbacks - $feedbacks = get_records('feedback', 'course', $course); + $feedbacks = $DB->get_records('feedback', array('course'=>$course)); if($feedbacks) { foreach($feedbacks as $feedback) { - $count += count_records('feedback_completed', 'feedback', $feedback->id); + $count += $DB->count_records('feedback_completed', array('feedback'=>$feedback->id)); } } return $count; diff --git a/mod/feedback/complete.php b/mod/feedback/complete.php index c0ea3790e9..c869083347 100644 --- a/mod/feedback/complete.php +++ b/mod/feedback/complete.php @@ -60,11 +60,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -86,9 +86,9 @@ } if($courseid AND $courseid != SITEID) { - $course2 = get_record('course', 'id', $courseid); + $course2 = $DB->get_record('course', array('id'=>$courseid)); require_course_login($course2); //this overwrites the object $course :-( - $course = get_record("course", "id", $cm->course); // the workaround + $course = $DB->get_record("course", array("id"=>$cm->course)); // the workaround } if(!$capabilities->complete) { @@ -179,7 +179,7 @@ }else{ $feedbackcompleted = false; } - $feedbackcompletedtmp = get_record('feedback_completedtmp', 'id', $completedid); + $feedbackcompletedtmp = $DB->get_record('feedback_completedtmp', array('id'=>$completedid)); //fake saving for switchrole $is_switchrole = feedback_check_is_switchrole(); if($is_switchrole) { @@ -194,11 +194,11 @@ feedback_send_email_anonym($cm, $feedback, $course, $userid); } //tracking the submit - $tracking = null; + $tracking = new object(); $tracking->userid = $USER->id; $tracking->feedback = $feedback->id; $tracking->completed = $new_completed_id; - insert_record('feedback_tracking', $tracking); + $DB->insert_record('feedback_tracking', $tracking); unset($SESSION->feedback->is_started); }else { @@ -222,16 +222,16 @@ } //get the feedbackitems after the last shown pagebreak - $feedbackitems = get_records_select('feedback_item', 'feedback = '.$feedback->id.' AND position > '.$startposition, 'position'); + $feedbackitems = $DB->get_records_select('feedback_item', 'feedback = ? AND position > ?', array($feedback->id, $startposition), 'position'); //get the first pagebreak - if($pagebreaks = get_records_select('feedback_item', "feedback = ".$feedback->id." AND typ = 'pagebreak'", 'position')) { + if($pagebreaks = $DB->get_records('feedback_item', array('feedback'=>$feedback->id, 'typ'=>'pagebreak'), 'position')) { $pagebreaks = array_values($pagebreaks); $firstpagebreak = $pagebreaks[0]; }else { $firstpagebreak = false; } - $maxitemcount = count_records('feedback_item', 'feedback', $feedback->id); + $maxitemcount = $DB->count_records('feedback_item', array('feedback'=>$feedback->id)); //get the values of completeds before done. Anonymous user can not get these values. if((!isset($SESSION->feedback->is_started)) AND (!isset($savereturn)) AND ($feedback->anonymous == FEEDBACK_ANONYMOUS_NO)) { @@ -267,6 +267,7 @@ } } if($feedback->site_after_submit) { +var_dump($feedback->site_after_submit); print_continue(feedback_encode_target_url($feedback->site_after_submit)); }else { if($courseid) { @@ -304,13 +305,13 @@ break; } //check, if there exists required-elements - $countreq = count_records('feedback_item', 'feedback', $feedback->id, 'required', 1); + $countreq = $DB->count_records('feedback_item', array('feedback'=>$feedback->id, 'required'=>1)); if($countreq > 0) { echo ''; } unset($startitem); - $itemnr = count_records_select('feedback_item', 'feedback = '. $feedback->id . ' AND hasvalue = 1 AND position < '.$startposition); + $itemnr = $DB->count_records_select('feedback_item', 'feedback = ? AND hasvalue = 1 AND position < ?', array($feedback->id, $startposition)); foreach($feedbackitems as $feedbackitem){ if(!isset($startitem)) { //avoid showing double pagebreaks diff --git a/mod/feedback/complete_guest.php b/mod/feedback/complete_guest.php index 658d2d9d52..1bd14f1494 100644 --- a/mod/feedback/complete_guest.php +++ b/mod/feedback/complete_guest.php @@ -58,11 +58,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -89,9 +89,9 @@ require_course_login($course); if($courseid AND $courseid != SITEID) { - $course2 = get_record('course', 'id', $courseid); + $course2 = $DB->get_record('course', array('id'=>$courseid)); require_course_login($course2); //this overwrites the object $course :-( - $course = get_record("course", "id", $cm->course); // the workaround + $course = $DB->get_record("course", array("id"=>$cm->course)); // the workaround } if(!$capabilities->complete) { @@ -136,7 +136,7 @@ //additional check for multiple-submit (prevent browsers back-button). the main-check is in view.php $feedback_can_submit = true; if($feedback->multiple_submit == 0 ) { - // if($multiple_count = get_record('feedback_tracking', 'userid', $USER->id, 'feedback', $feedback->id)) { + // if($multiple_count = $DB->get_record('feedback_tracking', array('userid'=>$USER->id, 'feedback'=>$feedback->id))) { if(feedback_is_already_submitted($feedback->id, $courseid)) { $feedback_can_submit = false; } @@ -177,7 +177,7 @@ //exists there any pagebreak, so there are values in the feedback_valuetmp $userid = $USER->id; //arb changed from 0 to $USER->id - no strict anonymous feedbacks - if it is a guest taking it then I want to know that it was a guest (at least in the data saved in the feedback tables) - $feedbackcompletedtmp = get_record('feedback_completedtmp', 'id', $completedid); + $feedbackcompletedtmp = $DB->get_record('feedback_completedtmp', array('id'=>$completedid)); //fake saving for switchrole $is_switchrole = feedback_check_is_switchrole(); @@ -209,15 +209,15 @@ } //get the feedbackitems after the last shown pagebreak - $feedbackitems = get_records_select('feedback_item', 'feedback = '.$feedback->id.' AND position > '.$startposition, 'position'); + $feedbackitems = $DB->get_records_select('feedback_item', 'feedback = ? AND position > ?', array($feedback->id, $startposition), 'position'); //get the first pagebreak - if($pagebreaks = get_records_select('feedback_item', "feedback = ".$feedback->id." AND typ = 'pagebreak'", 'position')) { + if($pagebreaks = $DB->get_records('feedback_item', array('feedback'=>$feedback->id, 'typ'=>'pagebreak'), 'position')) { $pagebreaks = array_values($pagebreaks); $firstpagebreak = $pagebreaks[0]; }else { $firstpagebreak = false; } - $maxitemcount = count_records('feedback_item', 'feedback', $feedback->id); + $maxitemcount = $DB->count_records('feedback_item', array('feedback'=>$feedback->id)); $feedbackcompletedtmp = feedback_get_current_completed($feedback->id, true, $courseid, $USER->sesskey); /// Print the main part of the page @@ -280,13 +280,13 @@   '; //check, if there exists required-elements - $countreq = count_records('feedback_item', 'feedback', $feedback->id, 'required', 1); + $countreq = $DB->count_records('feedback_item', array('feedback'=>$feedback->id, 'required'=>1)); if($countreq > 0) { echo ''; } unset($startitem); - $itemnr = count_records_select('feedback_item', 'feedback = '. $feedback->id . ' AND hasvalue = 1 AND position < '.$startposition); + $itemnr = $DB->count_records_select('feedback_item', 'feedback = ? AND hasvalue = 1 AND position < ?', array($feedback->id, $startposition)); foreach($feedbackitems as $feedbackitem){ if(!isset($startitem)) { //avoid showing double pagebreaks diff --git a/mod/feedback/delete_completed.php b/mod/feedback/delete_completed.php index 964ccdc8c8..7d303bd4a2 100644 --- a/mod/feedback/delete_completed.php +++ b/mod/feedback/delete_completed.php @@ -24,11 +24,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -53,7 +53,7 @@ } if(isset($formdata->confirmdelete) AND $formdata->confirmdelete == 1){ - if($completed = get_record('feedback_completed', 'id', $completedid)) { + if($completed = $DB->get_record('feedback_completed', array('id'=>$completedid))) { feedback_delete_completed($completedid); add_to_log($course->id, 'feedback', 'delete', 'view.php?id='.$cm->id, $feedback->id,$cm->id); redirect('show_entries.php?id='.$id.'&do_show=showentries'); diff --git a/mod/feedback/delete_item.php b/mod/feedback/delete_item.php index e1d0e5c25a..77cd3ec01c 100644 --- a/mod/feedback/delete_item.php +++ b/mod/feedback/delete_item.php @@ -20,11 +20,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } diff --git a/mod/feedback/delete_template.php b/mod/feedback/delete_template.php index ac26405d90..7f29f36923 100644 --- a/mod/feedback/delete_template.php +++ b/mod/feedback/delete_template.php @@ -34,11 +34,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } diff --git a/mod/feedback/edit.php b/mod/feedback/edit.php index 0f66ab7ab3..433c10b874 100644 --- a/mod/feedback/edit.php +++ b/mod/feedback/edit.php @@ -33,11 +33,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -51,21 +51,21 @@ //move up/down items if($moveupitem){ - $item = get_record('feedback_item', 'id', $moveupitem); + $item = $DB->get_record('feedback_item', array('id'=>$moveupitem)); feedback_moveup_item($item); } if($movedownitem){ - $item = get_record('feedback_item', 'id', $movedownitem); + $item = $DB->get_record('feedback_item', array('id'=>$movedownitem)); feedback_movedown_item($item); } //moving of items if($movehere && isset($SESSION->feedback->moving->movingitem)){ - $item = get_record('feedback_item', 'id', intval($SESSION->feedback->moving->movingitem)); + $item = $DB->get_record('feedback_item', array('id'=>$SESSION->feedback->moving->movingitem)); feedback_move_item($item, intval($movehere)); } if($moveitem){ - $item = get_record('feedback_item', 'id', $moveitem); + $item = $DB->get_record('feedback_item', array('id'=>$moveitem)); $SESSION->feedback->moving->shouldmoving = 1; $SESSION->feedback->moving->movingitem = $moveitem; } else { @@ -73,7 +73,7 @@ } if($switchitemrequired) { - $item = get_record('feedback_item', 'id', $switchitemrequired); + $item = $DB->get_record('feedback_item', array('id'=>$switchitemrequired)); @feedback_switch_item_required($item); redirect($ME.'?'.feedback_edit_get_default_query($id, $do_show)); exit; @@ -110,7 +110,7 @@ //get the feedbackitems $lastposition = 0; - $feedbackitems = get_records('feedback_item', 'feedback', $feedback->id, 'position'); + $feedbackitems = $DB->get_records('feedback_item', array('feedback'=>$feedback->id), 'position'); if(is_array($feedbackitems)){ $feedbackitems = array_values($feedbackitems); if(count($feedbackitems) > 0) { @@ -219,7 +219,7 @@ print_box_start('generalbox boxaligncenter boxwidthwide'); //check, if there exists required-elements - $countreq = count_records('feedback_item', 'feedback', $feedback->id, 'required', 1); + $countreq = $DB->count_records('feedback_item', array('feedback'=>$feedback->id), 'required', 1); if($countreq > 0) { // echo '(*)' . get_string('items_are_required', 'feedback') . ''; echo '(*)' . get_string('items_are_required', 'feedback') . ''; diff --git a/mod/feedback/edit_item.php b/mod/feedback/edit_item.php index 197a48d7a5..cd62883393 100644 --- a/mod/feedback/edit_item.php +++ b/mod/feedback/edit_item.php @@ -30,11 +30,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -55,7 +55,7 @@ //get the existing item or create it // $formdata->itemid = isset($formdata->itemid) ? $formdata->itemid : NULL; - if($itemid and $item = get_record('feedback_item', 'id', $itemid)){ + if($itemid and $item = $DB->get_record('feedback_item', array('id'=>$itemid))) { $typ = $item->typ; $position = $item->position; }else { @@ -82,7 +82,7 @@ if (!$newitemid = feedback_create_item($formdata)) { $SESSION->feedback->errors[] = get_string('item_creation_failed', 'feedback'); }else { - $newitem = get_record('feedback_item', 'id', $newitemid); + $newitem = $DB->get_record('feedback_item', array('id'=>$newitemid)); if (!feedback_move_item($newitem, $newposition)){ $SESSION->feedback->errors[] = get_string('item_creation_failed', 'feedback'); }else { @@ -148,7 +148,7 @@ $i_form->addElement('hidden', 'feedbackid', $feedback->id); - $lastposition = count_records('feedback_item', 'feedback', $feedback->id); + $lastposition = $DB->count_records('feedback_item', array('feedback'=>$feedback->id)); if($position == -1){ $i_formselect_last = $lastposition + 1; $i_formselect_value = $lastposition + 1; @@ -195,7 +195,7 @@ echo ''; //choose the position - $lastposition = count_records('feedback_item', 'feedback', $feedback->id); + $lastposition = $DB->count_records('feedback_item', array('feedback'=>$feedback->id)); echo get_string('position', 'feedback').' '; echo '
CourseAverage
(*)' . get_string('items_are_required', 'feedback') . '
(*)' . get_string('items_are_required', 'feedback') . '
@@ -223,7 +223,7 @@
'; if($feedbackitem->hasvalue == 1 AND $feedback->autonumbering) { $itemnr++; diff --git a/mod/feedback/show_entries_anonym.php b/mod/feedback/show_entries_anonym.php index 74f3e4e602..1e94ade7f0 100644 --- a/mod/feedback/show_entries_anonym.php +++ b/mod/feedback/show_entries_anonym.php @@ -26,11 +26,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -45,18 +45,18 @@ //get the completeds // if a new anonymous record has not been assigned a random response number - if ($feedbackcompleteds = get_records_select('feedback_completed','feedback='.$feedback->id.' AND random_response=0 AND anonymous_response='.FEEDBACK_ANONYMOUS_YES, 'random_response')){ //arb + if ($feedbackcompleteds = $DB->get_records('feedback_completed', array('feedback'=>$feedback->id, 'random_response'=>0, 'anonymous_response'=>FEEDBACK_ANONYMOUS_YES), 'random_response')){ //arb //then get all of the anonymous records and go through them - $feedbackcompleteds = get_records_select('feedback_completed','feedback='.$feedback->id.' AND anonymous_response='.FEEDBACK_ANONYMOUS_YES,'id'); //arb + $feedbackcompleteds = $DB->get_records('feedback_completed', array('feedback'=>$feedback->id, 'anonymous_response'=>FEEDBACK_ANONYMOUS_YES), 'id'); //arb shuffle($feedbackcompleteds); $num = 1; foreach($feedbackcompleteds as $compl){ $compl->random_response = $num; - update_record('feedback_completed', $compl); + $DB->update_record('feedback_completed', $compl); $num++; } } - $feedbackcompleteds = get_records_select('feedback_completed','feedback='.$feedback->id.' AND anonymous_response='.FEEDBACK_ANONYMOUS_YES, 'random_response'); //arb + $feedbackcompleteds = $DB->get_records('feedback_completed', array('feedback'=>$feedback->id, 'anonymous_response'=>FEEDBACK_ANONYMOUS_YES), 'random_response'); //arb /// Print the page header $strfeedbacks = get_string("modulenameplural", "feedback"); @@ -131,8 +131,8 @@ //print the items if(isset($formdata->showanonym) && $formdata->showanonym == FEEDBACK_ANONYMOUS_YES) { //get the feedbackitems - $feedbackitems = get_records('feedback_item', 'feedback', $feedback->id, 'position'); - $feedbackcompleted = get_record('feedback_completed', 'id', $formdata->completedid); + $feedbackitems = $DB->get_records('feedback_item', array('feedback'=>$feedback->id), 'position'); + $feedbackcompleted = $DB->get_record('feedback_completed', array('id'=>$formdata->completedid)); if(is_array($feedbackitems)){ if($feedbackcompleted) { echo '

'.get_string('chosen_feedback_response', 'feedback').'
('.get_string('anonymous', 'feedback').')

';//arb @@ -147,7 +147,7 @@ $itemnr = 0; foreach($feedbackitems as $feedbackitem){ //get the values - $value = get_record_select('feedback_value','completed ='.$feedbackcompleted->id.' AND item='.$feedbackitem->id); + $value = $DB->get_record('feedback_value', array('completed'=>$feedbackcompleted->id, 'item'=>$feedbackitem->id)); echo ''; if($feedbackitem->hasvalue == 1 AND $feedback->autonumbering) { $itemnr++; diff --git a/mod/feedback/unmapcourse.php b/mod/feedback/unmapcourse.php index 2b73bfc2aa..3cfd773c70 100644 --- a/mod/feedback/unmapcourse.php +++ b/mod/feedback/unmapcourse.php @@ -19,11 +19,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -37,7 +37,7 @@ // cleanup all lost entries after deleting courses or feedbacks feedback_clean_up_sitecourse_map(); - if (delete_records('feedback_sitecourse_map', 'id', $cmapid)) { + if ($DB->delete_records('feedback_sitecourse_map', array('id'=>$cmapid))) { redirect (htmlspecialchars('mapcourse.php?id='.$id)); } else { error('Database problem, unable to unmap'); diff --git a/mod/feedback/use_templ.php b/mod/feedback/use_templ.php index 39053ac13c..5580922db4 100644 --- a/mod/feedback/use_templ.php +++ b/mod/feedback/use_templ.php @@ -25,11 +25,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -88,7 +88,7 @@ // print_simple_box_end(); print_box_end(); - $templateitems = get_records('feedback_item', 'template', $templateid, 'position'); + $templateitems = $DB->get_records('feedback_item', array('template'=>$templateid), 'position'); if(is_array($templateitems)){ $templateitems = array_values($templateitems); } diff --git a/mod/feedback/view.php b/mod/feedback/view.php index 0190d08687..762dc167b2 100644 --- a/mod/feedback/view.php +++ b/mod/feedback/view.php @@ -21,11 +21,11 @@ error("Course Module ID was incorrect"); } - if (! $course = get_record("course", "id", $cm->course)) { + if (! $course = $DB->get_record("course", array("id"=>$cm->course))) { error("Course is misconfigured"); } - if (! $feedback = get_record("feedback", "id", $cm->instance)) { + if (! $feedback = $DB->get_record("feedback", array("id"=>$cm->instance))) { error("Course module is incorrect"); } } @@ -96,7 +96,7 @@ } if( (intval($feedback->publish_stats) == 1) AND !( $capabilities->viewreports) ) { - if($multiple_count = count_records('feedback_tracking', 'userid', $USER->id, 'feedback', $feedback->id)) { + if($multiple_count = $DB->count_records('feedback_tracking', array('userid'=>$USER->id, 'feedback'=>$feedback->id))) { echo '
'; echo get_string('completed_feedbacks', 'feedback').''; echo '
';
-  (id.' AND anonymous_response='.FEEDBACK_ANONYMOUS_YES);?>) +  (count_records('feedback_completed', array('feedback'=>$feedback->id, 'anonymous_response'=>FEEDBACK_ANONYMOUS_YES));?>) userid); + $usr = $DB->get_record('user', array('id'=>$formdata->userid)); if($feedbackcompleted) { echo '

'.UserDate($feedbackcompleted->timemodified).'
('.fullname($usr).')

'; } else { @@ -264,7 +264,7 @@ $itemnr = 0; foreach($feedbackitems as $feedbackitem){ //get the values - $value = get_record_select('feedback_value','completed ='.$feedbackcompleted->id.' AND item='.$feedbackitem->id); + $value = $DB->get_record('feedback_value', array('completed'=>$feedbackcompleted->id, 'item'=>$feedbackitem->id)); echo '