From: danmarsden <danmarsden>
Date: Thu, 26 Mar 2009 20:22:43 +0000 (+0000)
Subject: AICC  MDL-18702 Completion Logic incorrect - thanks to Martin Holden for the fix!
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=0362f013207b2515499c19e45dee3e648a168e05;p=moodle.git

AICC  MDL-18702 Completion Logic incorrect - thanks to Martin Holden for the fix!
---

diff --git a/mod/scorm/aicc.php b/mod/scorm/aicc.php
index 672834591d..0f46d6c228 100755
--- a/mod/scorm/aicc.php
+++ b/mod/scorm/aicc.php
@@ -265,10 +265,14 @@
                             if ($mode == 'normal') {
                                 if ($lessonstatus == 'completed') {
                                     if ($sco = scorm_get_sco($scoid)) {
-                                        if (!empty($sco->mastery_score) && !empty($score) && ($score >= $sco->mastery_score)) {
-                                            $lessonstatus = 'passed';
-                                        } else {
-                                            $lessonstatus = 'failed';
+                                        if (!empty($sco->mastery_score)) {
+                                            if (!empty($score)) {
+                                                if ($score >= $sco->mastery_score) {
+                                                    $lessonstatus = 'passed';
+                                                } else {
+                                                    $lessonstatus = 'failed';
+                                                }
+                                            }
                                         }
                                         $id = scorm_insert_track($USER->id, $scorm->id, $sco->id, $attempt, 'cmi.core.lesson_status', $lessonstatus);
                                     }