From: stronk7 <stronk7>
Date: Mon, 11 May 2009 00:04:18 +0000 (+0000)
Subject: MDL-18746 get_user_courses_bycap() - avoid ambiguous (repeated) column names ; merged... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=09740513070df5e917062706d7ea10d3130d0867;p=moodle.git

MDL-18746 get_user_courses_bycap() - avoid ambiguous (repeated) column names ; merged from 19_STABLE
---

diff --git a/lib/accesslib.php b/lib/accesslib.php
index dc2c239d6b..1830ce6f37 100755
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -1069,6 +1069,11 @@ function get_user_courses_bycap($userid, $cap, $accessdata, $doanything, $sort='
     } else {
         $fields = $basefields;
     }
+    // If any of the fields is '*', leave it alone, discarding the rest
+    // to avoid ambiguous columns under some silly DBs. See MDL-18746 :-D
+    if (in_array('*', $fields)) {
+        $fields = array('*');
+    }
     $coursefields = 'c.' .implode(',c.', $fields);
 
     $sort = trim($sort);